[1.14] Change plugin_dir to plugin_dirs#2422
Merged
openshift-merge-robot merged 1 commit intocri-o:release-1.14from May 30, 2019
Merged
[1.14] Change plugin_dir to plugin_dirs#2422openshift-merge-robot merged 1 commit intocri-o:release-1.14from
openshift-merge-robot merged 1 commit intocri-o:release-1.14from
Conversation
openshift-ci-robot
added
the
dco-signoff: yes
openshift-ci-robot
added
the
size/M
haircommander
changed the title
vrothberg
reviewed
May 29, 2019
Member
vrothberg
left a comment
vrothberg
left a comment
There was a problem hiding this comment.
Changes LGTM but maybe we can add a test?
mrunalp
reviewed
May 29, 2019
haircommander
force-pushed
the
plugin-dirs
branch
2 times, most recently
from
caceeb7 to
133cbbb
Compare
umohnani8
reviewed
May 29, 2019
Member
|
one nit, otherwise LGTM |
haircommander
force-pushed
the
plugin-dirs
branch
from
133cbbb to
d4b5f12
Compare
To maintain backwards compatibility, change plugin_dir to plugin_dirs in crio configs. Mark plugin_dir depreciated, and send warning as such. Signed-off-by: Peter Hunt <pehunt@redhat.com>
haircommander
force-pushed
the
plugin-dirs
branch
from
d4b5f12 to
22bc07a
Compare
Member
Author
|
/retest |
Codecov Report
@@ Coverage Diff @@
## release-1.14 #2422 +/- ##
================================================
+ Coverage 31.23% 31.29% +0.05%
================================================
Files 76 76
Lines 6831 6836 +5
================================================
+ Hits 2134 2139 +5
Misses 4569 4569
Partials 128 128 |
Member
Author
|
/retest |
jpeach
reviewed
May 30, 2019
Member
|
/approve |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To maintain backwards compatibility, change plugin_dir to plugin_dirs in crio configs.
Mark plugin_dir depreciated, and send warning as such.
Signed-off-by: Peter Hunt pehunt@redhat.com