Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#192: Support multiple IdP signing certificates #193

Merged
merged 2 commits into from
May 1, 2019
Merged

#192: Support multiple IdP signing certificates #193

merged 2 commits into from
May 1, 2019

Conversation

jskress
Copy link
Contributor

@jskress jskress commented May 1, 2019

This change updates service_provider.go to create an array of signing certificates from all those found in the IdP metadata. Issue #192 has details about why this is necessary.

Connected to #192

@jskress
Copy link
Contributor Author

jskress commented May 1, 2019

I don't know why the build failed. It was in duration_test.go, line 75. The offending case looks like line 55. The failure looks like a pointer comparison problem. Any thoughts?

@crewjam
Copy link
Owner

crewjam commented May 1, 2019

can you take a look at why the tests didn't pass please?

@jskress
Copy link
Contributor Author

jskress commented May 1, 2019

Looks like the error is on the Go tip only and has been there awhile. The Go 1.9 job passes.

@jskress
Copy link
Contributor Author

jskress commented May 1, 2019

I believe that this may have to do with changes Go made in errors and DeepEquals. If we change line 75 in duration_test.go, to read something like,

    if tc.err == nil {
        c.Assert(err, IsNil)
    } else {
        c.Assert(err.Error(), Equals, tc.err.Error())
    }

That should do the validation needed. Shall I add that to the PR?

@jskress
Copy link
Contributor Author

jskress commented May 1, 2019

Yep. That was it. Build passes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants