Fix JSON console formatting for tool inputs #3476
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Parse JSON strings in tool inputs for better readability - Add proper error handling for malformed JSON - Maintain existing string formatting as fallback - Add comprehensive tests covering various input scenarios Fixes #3474 Co-Authored-By: João <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Replace assert statements with mock_print.assert_called() to fix S101 linting errors - Maintain test functionality while following project linting standards Co-Authored-By: João <[email protected]>
- Add ClassVar import for proper type annotation - Fix variable shadowing by renaming nested loop variables - Break long comment lines to meet 88 character limit - All lint checks now pass locally Co-Authored-By: João <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix JSON console formatting for tool inputs
Summary
Fixes issue #3474 by improving the readability of tool inputs in console output. Previously, tool inputs containing JSON were displayed as long, unreadable strings. This change attempts to parse tool inputs as JSON and formats them with proper indentation and syntax highlighting for better readability.
Core change: In
ConsoleFormatter.handle_agent_logs_execution(), tool inputs are now parsed withjson.loads()before formatting. If JSON parsing fails, the system gracefully falls back to the original string formatting behavior.Additional changes: Modernized type annotations throughout the file (e.g.,
Optional[Tree]→Tree | None,Dict→dict) and reorganized imports for better consistency.Review & Testing Checklist for Human
uv run pytest tests -vvto verify no regressions (my testing was limited due to pytest plugin conflicts)Notes