Fixed JSON formatting #3475
Open
Fixed JSON formatting #3475
+142
−127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before After |
Vidit-Ostwal
commented
Sep 7, 2025
| agent_role = agent_role.partition("\n")[0] | ||
|
|
||
| if isinstance(formatted_answer, AgentAction): | ||
| thought = re.sub(r"\n+", "\n", formatted_answer.thought) | ||
| formatted_json = json.dumps( | ||
| formatted_answer.tool_input, | ||
| json.loads(formatted_answer.tool_input), |
There was a problem hiding this comment.
This is the only change done, rest are the linting changes
Comment on lines
+1592
to
+1606
| sources_branch = None | ||
|
|
||
| # Try to find an existing "Sources Used" branch | ||
| for sub_child in child.children: | ||
| if "Sources Used" in str(sub_child.label): | ||
| sources_branch = sub_child | ||
| break | ||
| else: | ||
| sources_branch = child.add("Sources Used") | ||
| sources_branch.add(f"✅ {memory_type} ({query_time_ms:.2f}ms)") | ||
| break | ||
|
|
||
| # If not found, create it under this child | ||
| if sources_branch is None: | ||
| sources_branch = child.add("🧠 Sources Used") | ||
|
|
||
| sources_branch.add(f"✅ {memory_type} ({query_time_ms:.2f}ms)") | ||
| break | ||
|
|
There was a problem hiding this comment.
This is was a logic change done, because of linter.
Comment on lines
+1631
to
+1645
| sources_branch = None | ||
|
|
||
| # Try to find an existing "Sources Used" branch | ||
| for sub_child in child.children: | ||
| if "Sources Used" in str(sub_child.label): | ||
| sources_branch = sub_child | ||
| break | ||
| else: | ||
|
|
||
| # If not found, create it under this child | ||
| if sources_branch is None: | ||
| sources_branch = child.add("🧠 Sources Used") | ||
| sources_branch.add(f"❌ {memory_type} - Error: {error}") | ||
| break | ||
|
|
||
| sources_branch.add(f"❌ {memory_type} - Error: {error}") | ||
| break | ||
|
|
There was a problem hiding this comment.
This one as well
|
Requesting @lorenzejay for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the tool input console formatting
Fixes #3474