Develop #132
Merged
Develop #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Par contre comme j'ai fais un merge de mon autre branche (basee sur master) la pull request contient d'autres commits. Si tu preferes que je refasse une request avec du cherry-pick fais moi savoir. |
|
Effectivement cela serait plus propre |
|
Voila c'est fait. |
|
|
||
| EmailNotifier: | ||
| status: | ||
| enabled: 1 |
There was a problem hiding this comment.
Serait-il possible de mettre la valeur par défaut à 0, pour tous les types ?
|
Serait-il possible d'ajouter |
| @@ -26,12 +26,20 @@ public function getEventConfig($eventType) | |||
|
|
|||
| public function getCurrentProjectConfig() | |||
| { | |||
| return (isset($this->config['projects'][$this->arguments['project-id']])) ? $this->config['projects'][$this->arguments['project-id']] : array(); | |||
| $config = array(); | |||
| if(isset($this->config['projects'][$this->arguments['project-id']])) | |||
There was a problem hiding this comment.
Il faudrait ajouter des { }.
Dans les coding standards de Crew, on utilise toujours les accolades même s'il n'y a qu'une instruction.
|
Voila |
|
Merci 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Voila la nouvelle pull request