cargo crev fetch does not work with ssh URLs

[BatmanAoD]

I am unable to use crev fetch with git@ (ssh) URLs.

> RUST_BACKTRACE=1 cargo crev fetch url [email protected]:dpc/crev-proofs.git
Fetching [email protected]:dpc/crev-proofs.git... Error: authentication required but no callback set; class=Ssh (23)

Using the same fetch command with an https URL works.

crev was installed using cargo; I am running on Mac OS X Mojave (10.14.6).

> cargo crev --version
cargo-crev-crev 0.9.0

[dpc]

In principle the proof repos should be open for public. And we fetch them using libgit2 so handling authentication challenge might be tricky here.

Definitely low prio for me right now. "Just use https" for now. PRs always welcome though.

[BatmanAoD]

Fair enough; I was only using ssh accidentally. Just thought it was worth noting, especially in case someone else tries this and sees the same failure!

[dpc]

We could detect the link not be http(s) and warn the user...

[BatmanAoD]

I'm not sure that would have worked in my case, because I had a git config setting to replace https calls with git@ (for some reason that I don't remember). That wouldn't be detectable until after the git lib had done its thing, would it?

…

On Tue, Oct 8, 2019, 10:54 AM Dawid Ciężarkiewicz ***@***.***> wrote: We could detect the link not be http(s) and warn the user... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#249?email_source=notifications&email_token=AARU4T6KDS45FRMEFATND5DQNS3LJA5CNFSM4I6H3FTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAU3TJA#issuecomment-539605412>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARU4T27EPCFMVMADLY4SHDQNS3LJANCNFSM4I6H3FTA> .

[dpc]

Oh dear. I don't know. And it's a minor enough case, that I'll just ignore it for now. :D

[pickfire]

Yup, it affected me as well. I can't take fetch my own review. Because in my git config I did.

[url "[email protected]:pickfire"]
        insteadOf = https://github.com/pickfire

Is there any way to just force https in cargo crev?

ERROR: Error: Failed to fetch https://github.com/pickfire/crev-proofs: authentication required but no callback set; class=Ssh (23)

[dpc]

I doubt there's one generic way to force it. We could however (probably) register a callback or something and at very least print some useful info - like a link to a Wiki page. If anyone is feeling brave - please take a stab at writing a PR, otherwise we might get to it at some point. :)

[pickfire]

The issue is probably due to libgit2 rust-lang/git2-rs#600

git clone works with the same url though. Maybe once gitoxide crate can do cloning we can use that as alternative.