Maintenance updates. (#141)

* Update NGC version to June. * Change lockfile name to have a dash for consistency. * Update Ruff version. * Add GDB to NGC requirements for CLion projects. * Enable `ipc=host` by default (again).
cresset-template · Jul 6, 2023 · 7beff3e · 7beff3e
1 parent f968e11
commit 7beff3e
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 4 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -30,7 +30,7 @@ repos:
 
   # Ruff should be executed before other formatters.
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.0.272
+    rev: v0.0.277
     hooks:
       - id: ruff
         args: [--exit-non-zero-on-fix]

diff --git a/docker-compose.yaml b/docker-compose.yaml
@@ -43,7 +43,7 @@ services:
     image: ${IMAGE_NAME}
     network_mode: host # Use the same network as the host, may cause security issues.
     # `ipc: host` removes the shared memory cap but is a known security vulnerability.
-    #    ipc: host # Equivalent to `--ipc=host` in `docker run`. **Disable this on WSL.**
+    ipc: host # Equivalent to `--ipc=host` in `docker run`. **Disable this on WSL.**
     # shm_size: 1GB  # Explicit shared memory limit. No security issues this way.
     hostname: ${SERVICE} # Makes `pure` terminals easier to tell apart.
     extra_hosts: # Prevents "unknown host" issue when using `sudo`.
@@ -163,7 +163,7 @@ services:
       dockerfile: dockerfiles/ngc.Dockerfile
       args:
         NGC_YEAR: ${NGC_YEAR:-23}
-        NGC_MONTH: ${NGC_MONTH:-05}
+        NGC_MONTH: ${NGC_MONTH:-06}
 
   hub: # Service based on the official PyTorch Docker images from Docker Hub.
     extends: # Available images: https://hub.docker.com/r/pytorch/pytorch/tags

diff --git a/dockerfiles/simple.Dockerfile b/dockerfiles/simple.Dockerfile
@@ -103,7 +103,7 @@ ARG PYTHONUNBUFFERED=1
 
 ARG PATH=/opt/_conda/bin:$PATH
 COPY --link --from=lock-stash /opt/_conda /opt/_conda
-COPY --link ../reqs/simple.conda-lock.yaml /tmp/conda/lock.yaml
+COPY --link ../reqs/simple-conda-lock.yaml /tmp/conda/lock.yaml
 # Saves to `conda-linux-64.lock`, which can be installed via `conda create`.
 RUN conda-lock render -p linux-64 /tmp/conda/lock.yaml
 

diff --git a/reqs/ngc-apt.requirements.txt b/reqs/ngc-apt.requirements.txt
@@ -1,3 +1,4 @@
+gdb
 sudo
 tmux
 tzdata

diff --git a/reqs/simple.conda-lock.yaml → reqs/simple-conda-lock.yaml b/reqs/simple.conda-lock.yaml → reqs/simple-conda-lock.yaml
-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    gdb
     sudo
     tmux
     tzdata
@@ Expand Down @@