Merge #128 · crepererum-oss/pdatastructs.rs@44d4c8a

Commit

Merge #128

128: build(deps): bump actions/checkout from 3 to 4 r=crepererum a=dependabot[bot]

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v4.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update default runtime to node20 by <a href="https://github.com/takost"><code>`@takost</code></a>` in <a href="https://github.com/actions/checkout/pull/1436">actions/checkout#1436</a></li>
<li>Support fetching without the --progress option by <a href="https://github.com/simonbaird"><code>`@simonbaird</code></a>` in <a href="https://github.com/actions/checkout/pull/1067">actions/checkout#1067</a></li>
<li>Release 4.0.0 by <a href="https://github.com/takost"><code>`@takost</code></a>` in <a href="https://github.com/actions/checkout/pull/1447">actions/checkout#1447</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/takost"><code>`@takost</code></a>` made their first contribution in <a href="https://github.com/actions/checkout/pull/1436">actions/checkout#1436</a></li>
<li><a href="https://github.com/simonbaird"><code>`@simonbaird</code></a>` made their first contribution in <a href="https://github.com/actions/checkout/pull/1067">actions/checkout#1067</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v3...v4.0.0">https://github.com/actions/checkout/compare/v3...v4.0.0</a></p>
<h2>v3.6.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Mark test scripts with Bash'isms to be run via Bash by <a href="https://github.com/dscho"><code>`@dscho</code></a>` in <a href="https://github.com/actions/checkout/pull/1377">actions/checkout#1377</a></li>
<li>Add option to fetch tags even if fetch-depth &gt; 0 by <a href="https://github.com/RobertWieczoreck"><code>`@RobertWieczoreck</code></a>` in <a href="https://github.com/actions/checkout/pull/579">actions/checkout#579</a></li>
<li>Release 3.6.0 by <a href="https://github.com/luketomlinson"><code>`@luketomlinson</code></a>` in <a href="https://github.com/actions/checkout/pull/1437">actions/checkout#1437</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/RobertWieczoreck"><code>`@RobertWieczoreck</code></a>` made their first contribution in <a href="https://github.com/actions/checkout/pull/579">actions/checkout#579</a></li>
<li><a href="https://github.com/luketomlinson"><code>`@luketomlinson</code></a>` made their first contribution in <a href="https://github.com/actions/checkout/pull/1437">actions/checkout#1437</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v3.5.3...v3.6.0">https://github.com/actions/checkout/compare/v3.5.3...v3.6.0</a></p>
<h2>v3.5.3</h2>
<h2>What's Changed</h2>
<ul>
<li>Fix: Checkout Issue in self hosted runner due to faulty submodule check-ins by <a href="https://github.com/megamanics"><code>`@megamanics</code></a>` in <a href="https://github.com/actions/checkout/pull/1196">actions/checkout#1196</a></li>
<li>Fix typos found by codespell by <a href="https://github.com/DimitriPapadopoulos"><code>`@DimitriPapadopoulos</code></a>` in <a href="https://github.com/actions/checkout/pull/1287">actions/checkout#1287</a></li>
<li>Add support for sparse checkouts by <a href="https://github.com/dscho"><code>`@dscho</code></a>` and <a href="https://github.com/dfdez"><code>`@dfdez</code></a>` in <a href="https://github.com/actions/checkout/pull/1369">actions/checkout#1369</a></li>
<li>Release v3.5.3 by <a href="https://github.com/TingluoHuang"><code>`@TingluoHuang</code></a>` in <a href="https://github.com/actions/checkout/pull/1376">actions/checkout#1376</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/megamanics"><code>`@megamanics</code></a>` made their first contribution in <a href="https://github.com/actions/checkout/pull/1196">actions/checkout#1196</a></li>
<li><a href="https://github.com/DimitriPapadopoulos"><code>`@DimitriPapadopoulos</code></a>` made their first contribution in <a href="https://github.com/actions/checkout/pull/1287">actions/checkout#1287</a></li>
<li><a href="https://github.com/dfdez"><code>`@dfdez</code></a>` made their first contribution in <a href="https://github.com/actions/checkout/pull/1369">actions/checkout#1369</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v3...v3.5.3">https://github.com/actions/checkout/compare/v3...v3.5.3</a></p>
<h2>v3.5.2</h2>
<h2>What's Changed</h2>
<ul>
<li>Fix: Use correct API url / endpoint in GHES by <a href="https://github.com/fhammerl"><code>`@fhammerl</code></a>` in <a href="https://github.com/actions/checkout/pull/1289">actions/checkout#1289</a> based on <a href="https://github.com/actions/checkout/issues/1286">#1286</a> by <a href="https://github.com/1newsr"><code>`@1newsr</code></a></li>`
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v3.5.1...v3.5.2">https://github.com/actions/checkout/compare/v3.5.1...v3.5.2</a></p>
<h2>v3.5.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Improve checkout performance on Windows runners by upgrading <code>`@actions/github</code>` dependency by <a href="https://github.com/BrettDong"><code>`@BrettDong</code></a>` in <a href="https://github.com/actions/checkout/pull/1246">actions/checkout#1246</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/BrettDong"><code>`@BrettDong</code></a>` made their first contribution in <a href="https://github.com/actions/checkout/pull/1246">actions/checkout#1246</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v4.0.0</h2>
<ul>
<li><a href="https://github.com/actions/checkout/pull/1067">Support fetching without the --progress option</a></li>
<li><a href="https://github.com/actions/checkout/pull/1436">Update to node20</a></li>
</ul>
<h2>v3.6.0</h2>
<ul>
<li><a href="https://github.com/actions/checkout/pull/1377">Fix: Mark test scripts with Bash'isms to be run via Bash</a></li>
<li><a href="https://github.com/actions/checkout/pull/579">Add option to fetch tags even if fetch-depth &gt; 0</a></li>
</ul>
<h2>v3.5.3</h2>
<ul>
<li><a href="https://github.com/actions/checkout/pull/1196">Fix: Checkout fail in self-hosted runners when faulty submodule are checked-in</a></li>
<li><a href="https://github.com/actions/checkout/pull/1287">Fix typos found by codespell</a></li>
<li><a href="https://github.com/actions/checkout/pull/1369">Add support for sparse checkouts</a></li>
</ul>
<h2>v3.5.2</h2>
<ul>
<li><a href="https://github.com/actions/checkout/pull/1289">Fix api endpoint for GHES</a></li>
</ul>
<h2>v3.5.1</h2>
<ul>
<li><a href="https://github.com/actions/checkout/pull/1246">Fix slow checkout on Windows</a></li>
</ul>
<h2>v3.5.0</h2>
<ul>
<li><a href="https://github.com/actions/checkout/pull/1237">Add new public key for known_hosts</a></li>
</ul>
<h2>v3.4.0</h2>
<ul>
<li><a href="https://github.com/actions/checkout/pull/1209">Upgrade codeql actions to v2</a></li>
<li><a href="https://github.com/actions/checkout/pull/1210">Upgrade dependencies</a></li>
<li><a href="https://github.com/actions/checkout/pull/1225">Upgrade <code>`@actions/io</code></a></li>`
</ul>
<h2>v3.3.0</h2>
<ul>
<li><a href="https://github.com/actions/checkout/pull/1045">Implement branch list using callbacks from exec function</a></li>
<li><a href="https://github.com/actions/checkout/pull/1050">Add in explicit reference to private checkout options</a></li>
<li>[Fix comment typos (that got added in <a href="https://github.com/actions/checkout/issues/770">#770</a>)](<a href="https://github.com/actions/checkout/pull/1057">actions/checkout#1057</a>)</li>
</ul>
<h2>v3.2.0</h2>
<ul>
<li><a href="https://github.com/actions/checkout/pull/942">Add GitHub Action to perform release</a></li>
<li><a href="https://github.com/actions/checkout/pull/967">Fix status badge</a></li>
<li><a href="https://github.com/actions/checkout/pull/1002">Replace datadog/squid with ubuntu/squid Docker image</a></li>
<li><a href="https://github.com/actions/checkout/pull/964">Wrap pipeline commands for submoduleForeach in quotes</a></li>
<li><a href="https://github.com/actions/checkout/pull/1029">Update <code>`@actions/io</code>` to 1.1.2</a></li>
<li><a href="https://github.com/actions/checkout/pull/1039">Upgrading version to 3.2.0</a></li>
</ul>
<h2>v3.1.0</h2>
<ul>
<li><a href="https://github.com/actions/checkout/pull/939">Use <code>`@actions/core</code>` <code>saveState</code> and <code>getState</code></a></li>
<li><a href="https://github.com/actions/checkout/pull/922">Add <code>github-server-url</code> input</a></li>
</ul>
<h2>v3.0.2</h2>
<ul>
<li><a href="https://github.com/actions/checkout/pull/770">Add input <code>set-safe-directory</code></a></li>
</ul>
<h2>v3.0.1</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/checkout/commit/3df4ab11eba7bda6032a0b82a6bb43b11571feac"><code>3df4ab1</code></a> Release 4.0.0 (<a href="https://github.com/actions/checkout/issues/1447">#1447</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/8b5e8b768746b50394015010d25e690bfab9dfbc"><code>8b5e8b7</code></a> Support fetching without the --progress option (<a href="https://github.com/actions/checkout/issues/1067">#1067</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/97a652b80035363df47baee5031ec8670b8878ac"><code>97a652b</code></a> Update default runtime to node20 (<a href="https://github.com/actions/checkout/issues/1436">#1436</a>)</li>
<li>See full diff in <a href="https://github.com/actions/checkout/compare/v3...v4">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=3&new-version=4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marco Neumann <[email protected]>

Loading branch information

3 people authored Sep 5, 2023

2 parents 8693710 + 5fed6f8 commit 44d4c8a

.github/workflows/ci.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -24,7 +24,7 @@ jobs: @@
               - nightly
         steps:
           - name: Checkout
-            uses: actions/checkout@v3
+            uses: actions/checkout@v4
           - name: Install Toolchain
             uses: actions-rs/[email protected]
@@ Expand Down @@

benches/filters.rs

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -92,16 +92,16 @@ fn benchmarks_insert_many(c: &mut Criterion) {
  
        g.sample_size(20);

        for n in [4_000, 8_000, 12_000, 16_000, 20_000] {

            g.bench_with_input(BenchmarkId::new(ID_BLOOMFILTER, &n), &n, |b, n| {

            g.bench_with_input(BenchmarkId::new(ID_BLOOMFILTER, n), &n, |b, n| {

                run_insert_many(setup_bloomfilter, b, *n)

            });

            g.bench_with_input(BenchmarkId::new(ID_CUCKOOFILTER, &n), &n, |b, n| {

            g.bench_with_input(BenchmarkId::new(ID_CUCKOOFILTER, n), &n, |b, n| {

                run_insert_many(setup_cuckoofilter, b, *n)

            });

            g.bench_with_input(BenchmarkId::new(ID_HASHSET, &n), &n, |b, n| {

            g.bench_with_input(BenchmarkId::new(ID_HASHSET, n), &n, |b, n| {

                run_insert_many(setup_hashset, b, *n)

            });

            g.bench_with_input(BenchmarkId::new(ID_QUOTIENTFILTER, &n), &n, |b, n| {

            g.bench_with_input(BenchmarkId::new(ID_QUOTIENTFILTER, n), &n, |b, n| {

                run_insert_many(setup_quotientfilter, b, *n)

            });

        }

    @@ -115,16 +115,16 @@ fn benchmarks_query_single(c: &mut Criterion) {
  
        g.sample_size(20);

        for n in [4_000, 8_000] {

            g.bench_with_input(BenchmarkId::new(ID_BLOOMFILTER, &n), &n, |b, n| {

            g.bench_with_input(BenchmarkId::new(ID_BLOOMFILTER, n), &n, |b, n| {

                run_query_single(setup_bloomfilter, b, *n)

            });

            g.bench_with_input(BenchmarkId::new(ID_CUCKOOFILTER, &n), &n, |b, n| {

            g.bench_with_input(BenchmarkId::new(ID_CUCKOOFILTER, n), &n, |b, n| {

                run_query_single(setup_cuckoofilter, b, *n)

            });

            g.bench_with_input(BenchmarkId::new(ID_HASHSET, &n), &n, |b, n| {

            g.bench_with_input(BenchmarkId::new(ID_HASHSET, n), &n, |b, n| {

                run_query_single(setup_hashset, b, *n)

            });

            g.bench_with_input(BenchmarkId::new(ID_QUOTIENTFILTER, &n), &n, |b, n| {

            g.bench_with_input(BenchmarkId::new(ID_QUOTIENTFILTER, n), &n, |b, n| {

                run_query_single(setup_quotientfilter, b, *n)

            });

        }

src/hyperloglog.rs

-Original file line number
+Diff line change
@@ Expand Up / @@ -596,7 +596,7 @@ mod tests { @@
         fn slice() {
             let mut hll: HyperLogLog<[u8]> = HyperLogLog::new(4);
             {
-                let v = vec![0];
+                let v = [0];
                 hll.add(&v[..]);
             }
             // `hll` is still usable after `v` is dropped:
@@ Expand Down @@

src/lib.rs

-Original file line number
+Diff line change
@@ Expand Up / @@ -6,7 +6,6 @@ @@
         clippy::explicit_iter_loop,
         clippy::future_not_send,
         clippy::use_self,
-        const_err,
         dead_code,
         illegal_floating_point_literal_pattern,
         missing_copy_implementations,
@@ Expand Down @@

src/reservoirsampling.rs

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -123,7 +123,7 @@ where
  
                // calculate next skip

                let p = (self.k as f64) / ((self.i + 1) as f64);

                let u = 1f64 - self.rng.gen_range((0.)..(1.)); // (0.0, 1.0]

                let u = 1f64 - self.rng.gen_range((0.)..1.); // (0.0, 1.0]

                let g = (u.ln() / (1. - p).ln()).floor() as usize;

                self.skip_until = self.i + g;

            }

src/topk/cmsheap.rs

-Original file line number
+Diff line change
@@ Expand Up / @@ -44,11 +44,7 @@ where @@
         T: Eq + Ord,
     {
         fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
-            match self.n.cmp(&other.n) {
-                Ordering::Greater => Some(Ordering::Greater),
-                Ordering::Less => Some(Ordering::Less),
-                Ordering::Equal => Some(self.obj.cmp(&other.obj)),
-            }
+            Some(self.cmp(other))
         }
     }
@@ Expand All / @@ -57,7 +53,11 @@ where @@
         T: Eq + Ord,
     {
         fn cmp(&self, other: &Self) -> Ordering {
-            self.partial_cmp(other).unwrap()
+            match self.n.cmp(&other.n) {
+                Ordering::Greater => Ordering::Greater,
+                Ordering::Less => Ordering::Less,
+                Ordering::Equal => self.obj.cmp(&other.obj),
+            }
         }
     }
@@ Expand Down @@

src/topk/lossycounter.rs

-Original file line number
+Diff line change
@@ Expand Up / @@ -231,7 +231,7 @@ where @@
             // add new data
             let was_new = match self.known.entry(t) {
                 Entry::Occupied(mut o) => {
-                    let mut value = o.get_mut();
+                    let value = o.get_mut();
                     value.f += 1;
                     false
                 }
@@ Expand Down @@

0 comments on commit `44d4c8a`

Please sign in to comment.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Commit

There are no files selected for viewing

0 comments on commit `44d4c8a`

Commit

There are no files selected for viewing

0 comments on commit 44d4c8a

0 comments on commit `44d4c8a`