Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add STDistanceSphere and Test to MySql #158

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

reneszabo
Copy link

No description provided.

@sadortun
Copy link
Member

sadortun commented Jun 9, 2016

You have protected $platforms = array('mysql'); and $this->supportsPlatform('postgresql'); in your test. Is it a typo ?

@sadortun
Copy link
Member

sadortun commented Jun 9, 2016

Hi @reneszabo Please have a look at the tests https://travis-ci.org/creof/doctrine2-spatial/jobs/136486440#L310

PHP Fatal error:  Cannot redeclare class CrEOF\Spatial\Tests\ORM\Query\AST\Functions\PostgreSql\STDistanceSphereTest in /home/travis/build/creof/doctrine2-spatial/tests/CrEOF/Spatial/Tests/ORM/Query/AST/Functions/PostgreSql/STDistanceSphereTest.php on line 91

@basz
Copy link

basz commented Oct 23, 2016

I could use this.
@reneszabo are you able to fix that typo?

* SOFTWARE.
*/

namespace CrEOF\Spatial\Tests\ORM\Query\AST\Functions\PostgreSql;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong namespace shoud be namespace CrEOF\Spatial\Tests\ORM\Query\AST\Functions\MySql;

protected function setUp()
{
$this->usesEntity(self::POINT_ENTITY);
$this->supportsPlatform('postgresql');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mysql?

@svycka
Copy link

svycka commented Jun 14, 2017

would be nice to have this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants