Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata changes now showing in notification hooks #85

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

tvhdev
Copy link

@tvhdev tvhdev commented Nov 27, 2022

a small patch to include metadata changes in notification hooks, please consider!

@creecros creecros merged commit c4c00b9 into creecros:master Dec 6, 2022
@creecros
Copy link
Owner

creecros commented Jan 25, 2023

#87 This PR is causing issue.

there is no callback in the array_filter $values = array_filter($values); line 36 of NewTaskModificationModel, which results in removing empty values, thus you cannot unassign a task.

before removing it, im trying to understand the original intent as to why this line exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants