Skip to content
This repository has been archived by the owner on Aug 10, 2022. It is now read-only.

Eslint prettier #87

Merged
merged 11 commits into from
Apr 20, 2022
Merged

Eslint prettier #87

merged 11 commits into from
Apr 20, 2022

Conversation

BartDeCaluwe
Copy link
Collaborator

@BartDeCaluwe BartDeCaluwe commented Apr 6, 2022

This PR will:

  • Add eslint and prettier config
  • Add linting step to pipeline
  • Linting and formatting changes caused by eslint

Checklist

  • I used the conventional commits specification.
  • Unit tests have been created if a new feature was added.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 6, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ef0b057
Status: ✅  Deploy successful!
Preview URL: https://7d4efff9.credix-app-v2.pages.dev

View logs

@BartDeCaluwe BartDeCaluwe force-pushed the eslint-prettier branch 2 times, most recently from ee341e8 to 750ce63 Compare April 6, 2022 11:18
@BartDeCaluwe BartDeCaluwe marked this pull request as ready for review April 6, 2022 11:23
@RuvendeGroote
Copy link
Contributor

is the prettier stuff being applied? you should add an entry to package.json to specify the prettier configuration to use + a format script and do it as a step in the pipeline

@BartDeCaluwe
Copy link
Collaborator Author

is the prettier stuff being applied? you should add an entry to package.json to specify the prettier configuration to use + a format script and do it as a step in the pipeline

Doesn't the linter do the prettier formatting as well? Or is that just because I specified it that way in my settings.
Ah but that won't mean it will be formatted in the pipeline as well. I'll add it!

@BartDeCaluwe BartDeCaluwe force-pushed the eslint-prettier branch 2 times, most recently from f5fe887 to 4d826a4 Compare April 8, 2022 09:44
@BouweCeunen
Copy link
Contributor

Small conflict still, also seems build is failing Type error: 'Component' cannot be used as a JSX component.

@BartDeCaluwe
Copy link
Collaborator Author

BartDeCaluwe commented Apr 11, 2022

Small conflict still, also seems build is failing Type error: 'Component' cannot be used as a JSX component.

Unfortunately the build is failing since last week because of this issue. I'm keeping my eye on that thread to see if any fix comes around.

RuvendeGroote
RuvendeGroote previously approved these changes Apr 20, 2022
.eslintrc.json Outdated Show resolved Hide resolved
@BartDeCaluwe BartDeCaluwe merged commit 2174b55 into localnet Apr 20, 2022
@BartDeCaluwe BartDeCaluwe deleted the eslint-prettier branch April 20, 2022 09:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants