Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed code analysis issues #500

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Fixed code analysis issues #500

merged 2 commits into from
Jan 15, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Description

Related Issue\Feature

How Has This Been Tested

  • All unit tests pass.
  • All integration tests pass.
  • Manual Testing:

Types of changes

  • Docs change
  • Refactoring
  • Dependency upgrade
  • Additional Unit Tests\Integration Tests
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Removed no-longer used code

Deployment Configuration Changes

  • Requires deployment configuration changes as specified below and in CHANGELOG.md

Checklist

  • There are no Resharper\static code analysis errors anywhere in the solution.
  • I have ONLY run a code clean-up on any files I have modified to make sure they are in the correct format and no others.
  • I have added tests to cover my changes.
  • I have run the code and quickly verified it all works to my satisfaction.
  • All new/modified code has sufficient logging to be able to diagnose what is wrong.
  • All new and existing tests passed.
  • All new/modified public interfaces/classes have are documented with xmldoc comments.
  • Unreleased section of CHANGELOG.md has been updated with details of this PR.

@credfeto credfeto marked this pull request as ready for review January 15, 2024 14:35
@credfeto credfeto merged commit 2a42ded into main Jan 15, 2024
39 checks passed
@credfeto credfeto deleted the depends/delete-me-too branch January 15, 2024 14:37
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant