Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: made reuqest Id parameter optional #841

Merged
merged 21 commits into from
Jul 12, 2024
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
c811f9d
fix: send email verification issue
bhavanakarwade Jul 2, 2024
8ee3ee5
Merge branch 'develop' of https://github.com/credebl/platform into fi…
bhavanakarwade Jul 3, 2024
5c98415
refcator: schema endorsement flow
bhavanakarwade Jul 5, 2024
b13e3a0
Merge branch 'develop' of https://github.com/credebl/platform into fi…
bhavanakarwade Jul 5, 2024
4f63200
fix: resolved sonar lint issues
bhavanakarwade Jul 5, 2024
80671ed
fix: worked on sonarcloud issues
bhavanakarwade Jul 5, 2024
4e7dd55
fix: delete organization bugs
bhavanakarwade Jul 8, 2024
bee5fc3
Merge branch 'develop' of https://github.com/credebl/platform into fi…
bhavanakarwade Jul 8, 2024
3b0936b
fix: cred def id space fixes
bhavanakarwade Jul 9, 2024
9c80531
Merge branch 'develop' of https://github.com/credebl/platform into fi…
bhavanakarwade Jul 9, 2024
81b19b7
Merge branch 'develop' of https://github.com/credebl/platform into fi…
bhavanakarwade Jul 10, 2024
62ca670
Merge branch 'develop' of https://github.com/credebl/platform into fi…
bhavanakarwade Jul 10, 2024
d90986e
fix: create organization bug
bhavanakarwade Jul 11, 2024
29cbe57
Merge branch 'develop' of https://github.com/credebl/platform into fi…
bhavanakarwade Jul 11, 2024
aebc54b
fix: pagination issue for preview file
bhavanakarwade Jul 11, 2024
a7c20cb
resolved conflicts
bhavanakarwade Jul 11, 2024
fe8035b
fix: pagination issue
bhavanakarwade Jul 11, 2024
60c9663
fix: imageurl issue in verification
bhavanakarwade Jul 11, 2024
6325d77
Merge branch 'develop' of https://github.com/credebl/platform into fi…
bhavanakarwade Jul 11, 2024
3f6a7de
Merge branch 'develop' of https://github.com/credebl/platform into fi…
bhavanakarwade Jul 12, 2024
e2c6ec0
fix: made request if parameter optional
bhavanakarwade Jul 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/api-gateway/src/issuance/dtos/issuance.dto.ts
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,8 @@ export class FileQuery {
}

export class RequestIdQuery {
@ApiProperty({ required: true })
@ApiPropertyOptional({ required: false })
@IsOptional()
@IsString({ message: 'requestId should be string' })
@IsNotEmpty({ message: 'requestId Id is required' })
@Transform(({ value }) => trim(value))
Expand Down