Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactored file_upload model and minor fix in issuance repository class. #834

Merged
merged 2 commits into from
Jul 10, 2024
Merged

fix: refactored file_upload model and minor fix in issuance repository class. #834

merged 2 commits into from
Jul 10, 2024

Conversation

ganeshawle25
Copy link
Contributor

What

  • Refactored file_upload model. Create migration file for new schema update.
  • Minor fix in issuance.repository.ts file.

@ganeshawle25 ganeshawle25 changed the title Feat/issued certificate statistics Refactored file_upload model Jul 10, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ganeshawle25 ganeshawle25 changed the title Refactored file_upload model fix: refactored file_upload model and minor fix in issuance repository class. Jul 10, 2024
@ganeshawle25 ganeshawle25 self-assigned this Jul 10, 2024
tipusinghaw
tipusinghaw approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@tipusinghaw tipusinghaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ganeshawle25 ganeshawle25 merged commit 3db34ce into develop Jul 10, 2024
2 checks passed
@tipusinghaw tipusinghaw deleted the feat/issued-certificate-statistics branch July 10, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhavanakarwade bhavanakarwade bhavanakarwade approved these changes

@tipusinghaw tipusinghaw tipusinghaw approved these changes

Assignees

@ganeshawle25 ganeshawle25

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganeshawle25 @tipusinghaw @bhavanakarwade