Refactor user and auth module APIs #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: pranalidhanavade <[email protected]>
…nto refactor-auth-module-api
Signed-off-by: pranalidhanavade <[email protected]>
…nto refactor-auth-module-api
Signed-off-by: pranalidhanavade <[email protected]>
pranalidhanavade
changed the title
| @@ -243,8 +243,7 @@ export class UserController { | |||
| /** | |||
| * | |||
| * @param email | |||
| * @param res | |||
| * @returns User email check | |||
| * @returns User's email exist status | |||
| */ | |||
| @Get('/:email') | |||
| @ApiOperation({ summary: 'Check user exist', description: 'check user existence' }) | |||
There was a problem hiding this comment.
Please replace summary and description with "Check if user exists"
| private readonly logger: Logger | ||
| ) {} | ||
|
|
||
| /** | ||
| * | ||
| * @param userEmailVerificationDto | ||
| * @param userEmailVerification | ||
| * @returns user email |
There was a problem hiding this comment.
Replace with "User's email"
Signed-off-by: pranalidhanavade <[email protected]>
|
pranalidhanavade
changed the title
vivekayanworks
approved these changes
Dec 27, 2023
14 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/auth/verifyto Verify user’s email./auth/verification-mailto Send verification mail./users/{email}to Check user exist.What
Promise<object>.How
Why