refactor: Template of Certificates #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ankita_patidar <[email protected]>
ankita-p17
requested review from
ajile-in,
KulkarniShashank and
vivekayanworks
|
Kudos, SonarCloud Quality Gate passed!
|
vivekayanworks
approved these changes
Dec 3, 2023
ankita-p17
changed the title
KulkarniShashank
pushed a commit
that referenced
this pull request
Sep 11, 2024
Signed-off-by: ankita_patidar <[email protected]>
KulkarniShashank
pushed a commit
that referenced
this pull request
Sep 11, 2024
Signed-off-by: ankita_patidar <[email protected]> Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank
pushed a commit
that referenced
this pull request
Sep 11, 2024
Signed-off-by: ankita_patidar <[email protected]> Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank
pushed a commit
that referenced
this pull request
Sep 11, 2024
Signed-off-by: ankita_patidar <[email protected]> Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank
pushed a commit
that referenced
this pull request
Sep 12, 2024
Signed-off-by: ankita_patidar <[email protected]> Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank
pushed a commit
that referenced
this pull request
Sep 12, 2024
Signed-off-by: ankita_patidar <[email protected]> Signed-off-by: KulkarniShashank <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removed dynamic IssuedBy attribute as it was coming from uploaded data and refactored the verbiage accordingly
Why?
As per client's requirement the name of the issuing organization on certificate is different from the one which will be issued as part of the credential
How?
Removed dynamic IssuedBy attribute from template and updated with 'IAM'
Anything Else?
NA