Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fetch ecosystem sent invitations #123

Merged
merged 5 commits into from
Oct 5, 2023
Merged

feat: fetch ecosystem sent invitations #123

merged 5 commits into from
Oct 5, 2023

Conversation

nishad-ayanworks
Copy link
Contributor

  • Worked on the GET API to fetch sent invitations to join ecosystem.

@nishad-ayanworks nishad-ayanworks self-assigned this Oct 5, 2023
tipusinghaw
tipusinghaw reviewed Oct 5, 2023
View reviewed changes
apps/api-gateway/src/ecosystem/dtos/get-all-sent-invitations.dto.ts Outdated
import { IsOptional } from 'class-validator';

export class GetAllEcosystemInvitationsDto {
@ApiProperty({ required: false })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@ApiProperty({ required: false })
@ApiProperty({ required: false, default: 1 })
@IsOptional()
@IsInt()
@Transform(({ value }) => parseInt(value, 10))
@Type(() => Number)
pageNumber: number;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

apps/ecosystem/src/ecosystem.service.ts
userId: string
): Promise<object> {
try {
const ecosystemInvitations = await this.ecosystemRepository.getInvitationsByEcosystemId(ecosystemId, pageNumber, pageSize, userId, search);
Copy link
Contributor

@tipusinghaw tipusinghaw Oct 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of destructuring the object in the service file we should destruct in the repository

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tipusinghaw
tipusinghaw approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@tipusinghaw tipusinghaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tipusinghaw tipusinghaw merged commit 612b1cb into develop Oct 5, 2023
3 checks passed
@tipusinghaw tipusinghaw deleted the 110-ecosystem-invite branch October 5, 2023 13:39
@nishad-ayanworks nishad-ayanworks linked an issue Oct 6, 2023 that may be closed by this pull request
feat: invite an organization to join Ecosystem (BE) #110
Closed
5 tasks
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@nishad-ayanworks @KulkarniShashank
feat: fetch ecosystem sent invitations (#123)
627449a 
* worked on the eslint issues

Signed-off-by: Nishad <[email protected]>

* worked on GET API sent invitation list to join ecosystem

Signed-off-by: Nishad <[email protected]>

* Solved promise issue in ecosystem repository

Signed-off-by: Nishad <[email protected]>

* Created interface for send invitation payload

Signed-off-by: Nishad <[email protected]>

---------

Signed-off-by: Nishad <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@nishad-ayanworks @KulkarniShashank
feat: fetch ecosystem sent invitations (#123)
ffe9f68 
* worked on the eslint issues

Signed-off-by: Nishad <[email protected]>

* worked on GET API sent invitation list to join ecosystem

Signed-off-by: Nishad <[email protected]>

* Solved promise issue in ecosystem repository

Signed-off-by: Nishad <[email protected]>

* Created interface for send invitation payload

Signed-off-by: Nishad <[email protected]>

---------

Signed-off-by: Nishad <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@nishad-ayanworks @KulkarniShashank
feat: fetch ecosystem sent invitations (#123)
4b65787 
* worked on the eslint issues

Signed-off-by: Nishad <[email protected]>

* worked on GET API sent invitation list to join ecosystem

Signed-off-by: Nishad <[email protected]>

* Solved promise issue in ecosystem repository

Signed-off-by: Nishad <[email protected]>

* Created interface for send invitation payload

Signed-off-by: Nishad <[email protected]>

---------

Signed-off-by: Nishad <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@nishad-ayanworks @KulkarniShashank
feat: fetch ecosystem sent invitations (#123)
fd14b4c 
* worked on the eslint issues

Signed-off-by: Nishad <[email protected]>

* worked on GET API sent invitation list to join ecosystem

Signed-off-by: Nishad <[email protected]>

* Solved promise issue in ecosystem repository

Signed-off-by: Nishad <[email protected]>

* Created interface for send invitation payload

Signed-off-by: Nishad <[email protected]>

---------

Signed-off-by: Nishad <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
@nishad-ayanworks @KulkarniShashank
feat: fetch ecosystem sent invitations (#123)
004fae1 
* worked on the eslint issues

Signed-off-by: Nishad <[email protected]>

* worked on GET API sent invitation list to join ecosystem

Signed-off-by: Nishad <[email protected]>

* Solved promise issue in ecosystem repository

Signed-off-by: Nishad <[email protected]>

* Created interface for send invitation payload

Signed-off-by: Nishad <[email protected]>

---------

Signed-off-by: Nishad <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
@nishad-ayanworks @KulkarniShashank
feat: fetch ecosystem sent invitations (#123)
9c2f00e 
* worked on the eslint issues

Signed-off-by: Nishad <[email protected]>

* worked on GET API sent invitation list to join ecosystem

Signed-off-by: Nishad <[email protected]>

* Solved promise issue in ecosystem repository

Signed-off-by: Nishad <[email protected]>

* Created interface for send invitation payload

Signed-off-by: Nishad <[email protected]>

---------

Signed-off-by: Nishad <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tipusinghaw tipusinghaw tipusinghaw approved these changes

Assignees

@nishad-ayanworks nishad-ayanworks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: invite an organization to join Ecosystem (BE)
2 participants
@nishad-ayanworks @tipusinghaw