-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restic: use repository-file if the repo flag contains a password #336
restic: use repository-file if the repo flag contains a password #336
Conversation
I guess this is to hide the password if someone looks at the process list? Makes sense 👍🏻 |
Exactly. A process list may also be sent by monitoring software so its easy to leak passwords around. |
fc5d88c
to
2c0d464
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #336 +/- ##
==========================================
+ Coverage 70.85% 71.02% +0.16%
==========================================
Files 121 121
Lines 12273 12373 +100
==========================================
+ Hits 8696 8787 +91
- Misses 3183 3190 +7
- Partials 394 396 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Tests are fixed and the enhancement disables itself when it detects that the repo is set by env variables |
also uses cast.ToBool to be on-par with vipers bool parsing from string
48f391b
to
c1d9cf4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it on one of my REST repo and it worked like a charm 🥇
Nice one! thanks 😉
Experimental PR to replace
restic --repo https://user:password@host
withrestic --repository-file /tmp/profile-repo.txt
(with file mode0600
)Currently fails tests (as they don't expect replacement) and depends on some functions from other PRs to complete it.