-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added prune as supported, schedulable command #24
Added prune as supported, schedulable command #24
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 42.83% 43.87% +1.04%
==========================================
Files 43 43
Lines 2762 2767 +5
==========================================
+ Hits 1183 1214 +31
+ Misses 1488 1462 -26
Partials 91 91
Continue to review full report at Codecov.
|
Self note: |
e9709b5
to
cdc41e4
Compare
Please note that the fix for |
Sure, I have been a bit busy, sorry about that. Thanks |
I see the two annoying files with CRLF ending, it's because sometimes I fix things on my work laptop. Sorry about that |
Yes sure, that would be great. |
Can you try a rebase now? |
Handles embedded structs that are annotated with `mapstructure:",squash"`
cdc41e4
to
63bbd5c
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Cool, thanks I like the way you refactored the scheduling config into I understand now why you had to change the code of the I'm looking at the newline issue; I realise the code of the |
It's ok for the Thanks fo the PR 👍🏻 |
Thanks a lot for reviewing and merging! |
Fixes #22
Implementation Notes:
profiles_test
&show
was checked in with forced CRLF (other files were not).The diff (without ignored whitespace) is larger than it should. Needs to be clarified if CRLF should be forced.
show
. Needs to be clarified if this should be fixed.Marked as WIP since I only tested it viaprofiles_test
and on my mac so far.Tested in regular backup schedule and via unit and manual tests.