Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme.md #69

Closed
wants to merge 3 commits into from
Closed

Update Readme.md #69

wants to merge 3 commits into from

Conversation

PreciousOritsedere
Copy link
Contributor

@PreciousOritsedere PreciousOritsedere commented Oct 12, 2022

Fixes

Fixes #68 by @PreciousOritsedere

Description

Added more distinctive instructions to the readme.md

Technical details

Tests

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@PreciousOritsedere PreciousOritsedere requested review from a team and possumbilities and removed request for a team October 12, 2022 08:39
@ImaJin14
Copy link
Contributor

ImaJin14 commented Oct 12, 2022

@PreciousOritsedere I think it's best you wait for PR #68 to be closed so we don't have duplicates

@PreciousOritsedere
Copy link
Contributor Author

I think @possumbilities or @TimidRobot is in the best position to review both and determine which one to close.

@PreciousOritsedere PreciousOritsedere mentioned this pull request Oct 12, 2022
7 tasks
@ImaJin14
Copy link
Contributor

This PR is already out of the scope of the linked issue

@PreciousOritsedere
Copy link
Contributor Author

@ImaJin14 how please? Can you explain further

@ImaJin14
Copy link
Contributor

Your issue states improvement on readme.md file but your commits show that you've changed more than just the readme.md file

I suggest you revert changes and resolve just the readme.md adjustments

@PreciousOritsedere
Copy link
Contributor Author

I was actually attempting to create another PR. But I think the commit merged into this. Because I couldn’t see the option to create a different Pr. I think the first one has to be merged first before I can create again

@possumbilities
Copy link
Contributor

possumbilities commented Oct 12, 2022

@PreciousOritsedere I'm grateful for your excitement to get started on this, but I'm going to close this PR since it's got extra changes not relevant to the Issue, and suggest you wait to try again until the original Issue #68 is fully approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants