Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved Searching Licensed Bug #259

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

crocmons
Copy link

@crocmons crocmons commented Oct 6, 2024

Fixes

Description

This pull request addresses the issue where certain sources on the Creative Commons search platform were not correctly filtering results based on CC licenses. Users might have inadvertently accessed non-CC licensed works due to this issue.

The sources affected include:

  • Soundcloud, Wikimedia Commons, and Google Images – where filtering for CC-licensed content was not applied correctly.
  • ccMixter – which was entirely broken and did not return any results.

The fix ensures that all these sources now return only CC-licensed content, or function properly in the case of ccMixter.

Technical details

  • The URL structures for the affected sources were updated to apply the correct CC license filtering.
  • Adjustments were made to the API integration to ensure proper data retrieval from each source.

Tests

  1. Verified that Soundcloud, Wikimedia Commons, and Google Images now correctly filter results to only show CC-licensed works.
  2. Tested ccMixter to confirm it returns results as expected.
  3. Ensured that other unaffected sources continue to function correctly.

Screenshots

1007.mp4

Checklist

  • My pull request has a descriptive title.
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow [best practices][best_practices].
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made.
  • I added or updated documentation (if applicable).
  • I verified the project locally and ensured there are no visible errors.

@crocmons crocmons requested a review from a team as a code owner October 6, 2024 19:21
@crocmons crocmons requested review from TimidRobot and possumbilities and removed request for a team October 6, 2024 19:21
Copy link

netlify bot commented Oct 6, 2024

Deploy Preview for cc-search-portal ready!

Name Link
🔨 Latest commit a439b8e
🔍 Latest deploy log https://app.netlify.com/sites/cc-search-portal/deploys/6720326aadc19700088435ca
😎 Deploy Preview https://deploy-preview-259--cc-search-portal.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@possumbilities possumbilities removed the request for review from TimidRobot October 7, 2024 14:38
@Netacci
Copy link
Contributor

Netacci commented Oct 8, 2024

This pr fixes this issue #250

@Netacci
Copy link
Contributor

Netacci commented Oct 8, 2024

This pr fixes thi

This pr fixes this issue #250

but when I added this pr at that time there was no mentioned pr there @Netacci

I'm just referencing the issue here @crocmons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Bug] Many "search using" sources are showing non CC-licensed results
2 participants