Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test for IconSelector.vue component #42

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

hamzanouali
Copy link

@hamzanouali hamzanouali commented Oct 2, 2019

add unit test for IconSelector.vue component

Description

IconSelector.vue component is responsible for rendering the license, it accept:

  • props: { id: String, icon: String , value: boolean }
  • click event which triggers input event with true or false.

example:

  • props: { id: 'sa', icon: 'sa', value: 'true' }
  • click event.
    result:
  • triggers input event with false, which means unselect the SA license.

Note:
default props:

  • SA's value could be true or false, which means it could be auto selected or no.
  • NC and ND's value must be true when mounting the component.

Checklist:

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Copy link
Member

@akmadian akmadian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, Hamza!

@akmadian akmadian merged commit e68ca10 into creativecommons:master Oct 3, 2019
@akmadian
Copy link
Member

akmadian commented Oct 3, 2019

Fixes #37

@hamzanouali
Copy link
Author

@akmadian , this is my first time I test somthing 🥇 I feel great 😄
thank you.

@hamzanouali
Copy link
Author

do you have something else to fix on this project or I should go to another one from Outreachy ?
another question, I should record this contribution now, right ?

@akmadian
Copy link
Member

akmadian commented Oct 3, 2019

Well, thanks for the help! I would find other CC repos to contribute to, as all the issues in cc-chooser are currently being worked on by others. As for recording the contribution, I'm not sure exactly how that works so I can't really say :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants