server: handle duplicate request IDs within a single batch #77
+96
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if two or more calls arrived in a single batch with the same request ID, the server would process the first one and report the rest as having duplicate IDs. This is subtly wrong, in that the client has no way of knowing which of the duplicates should get the successful call, and which should get the errors. Although a client sending such requests is already wrong, this makes the error harder to debug. Instead, check for duplicates within the batch during assignment, and fail all the colliding requests. Add a regression test for duplicate requests in a single batch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if two or more calls arrived in a single batch with the same request ID, the server would process the first one and report the rest as having duplicate IDs.
This is subtly wrong, in that the client has no way of knowing which of the duplicates should get the successful call, and which should get the errors. Although a client sending such requests is already wrong, this makes the error harder to debug.
Instead, check for duplicates within the batch during assignment, and fail all the colliding requests.