server: update context plumbing #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the Accept method to accept a context. This is a breaking change to the interface, but users of server.NetContext (which is most existing use) are not affected. Rework Loop as LoopContext, which now accepts a context that governs the loop. Retain Loop as a wrapper to call LoopContext with a background context, so existing use will work without change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Accepter interface to take a context argument.
This is a breaking change to the interface, but NetAccepter works
without change, so most existing use is not affected.
Rework Loop as LoopContext, which takes a context argument to
govern the lifecycle of the loop itself. Retain Loop as a wrapper
for LoopContext with a background context.
Update and clean up tests.