jhttp: set headers before calling WriteHeader

This was actually safe as written, but the API does not promise to honour headers set after the code is marked.
creachadair · Jan 15, 2022 · 5ac8637 · 5ac8637
1 parent 235ea4d
commit 5ac8637
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/jhttp/getter.go b/jhttp/getter.go
@@ -150,8 +150,8 @@ func writeJSON(w http.ResponseWriter, code int, obj interface{}) {
 		fmt.Fprintln(w, err.Error())
 		return
 	}
-	w.WriteHeader(code)
 	w.Header().Set("Content-Type", "application/json")
 	w.Header().Set("Content-Length", strconv.Itoa(len(bits)))
+	w.WriteHeader(code)
 	w.Write(bits)
 }