Merge structured output from henry_dev_rebase branch via temp #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LemmyTron
changed the title
chowington
requested changes
Nov 8, 2024
Comment on lines
216
to
221
| content = completion.choices[0].message.content | ||
| print("Response content:", content) | ||
| cost_logger.update_cost( | ||
| completion, input_cost=openai_config["model-costs"]["input"], output_cost=openai_config["model-costs"]["output"] | ||
| ) | ||
| return content |
There was a problem hiding this comment.
Here you'll want to work with and return message.parsed like in the other low-level structured outputs function, the one that I made. Then you'll need to bubble that up through the higher-level functions so they work with an object rather than a string (looks like you already did this to a certain degree)
Comment on lines
1275
to
1276
| class Decide_to_Talk(BaseModel): | ||
| decision: str |
There was a problem hiding this comment.
Since this response is just a "yes" or "no", a boolean might be more straightforward in this case. You'll want to update the prompting to reflect a boolean also
| @@ -1361,8 +1361,7 @@ def get_fail_safe(): | |||
| prompt = generate_prompt(prompt_input, prompt_template) | |||
|
|
|||
| fail_safe = get_fail_safe() | |||
| output = safe_generate_response(prompt, gpt_param, 5, fail_safe, | |||
| __func_validate, __func_clean_up) | |||
| output = generate_structured_response(prompt,gpt_param,Decide_to_Talk,5,fail_safe,__func_validate,__func_clean_up) | |||
There was a problem hiding this comment.
Can you fix the formatting in this line? Thanks!
| output = safe_generate_response(prompt, gpt_param, 5, fail_safe, | ||
| __func_validate, __func_clean_up) | ||
| output = ChatGPT_generate_structured_response(prompt, Convo_Takeaways,example_output, special_instruction, 3, fail_safe, __chat_func_validate, __chat_func_clean_up, True) |
There was a problem hiding this comment.
Can you swap in generate_structured_response instead here?
chowington
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add structured output from henry_dev_rebase branch via temp_pr_branch, fix output typo