This repository has been archived by the owner on Oct 27, 2022. It is now read-only.
Show the error in menu and status window #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
guillaumerose
commented
Jun 16, 2021
guillaumerose
commented
- Fetch the status every 5s
- Poll it since the beginning, remove the sleep(6s) which also blocked the UI
- Don't open an error dialog when status fails but show the error in the menu and status window.
If 2 calls are made at the same time, one call can override the connection used by the other.
Instead show the error in the menu and in the status window.
It avoids to lock the tray for 6s at startup. The daemon status is "Unknown" until the first status is shown.
anjannath
reviewed
Jun 16, 2021
| @@ -103,7 +95,8 @@ private static string getSocketResponse(string cmd) | |||
| { | |||
| try | |||
| { | |||
| Initialize(); | |||
| Socket daemonSocket = new Socket(AddressFamily.Unix, SocketType.Stream, ProtocolType.Unspecified); | |||
anjannath
reviewed
Jun 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.