Add monitoring operator in the CVO overrides before the cluster starts #294
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guillaumerose The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
It requires openshift/cluster-version-operator#488 |
guillaumerose
force-pushed
the
monitoring
branch
from
089fcd7 to
fdea4e2
Compare
guillaumerose
force-pushed
the
monitoring
branch
5 times, most recently
from
9ba3997 to
0550f17
Compare
|
/retest |
The operator will never run and won't create what we used to delete. It is cleaner and speed up a little bit cluster creation. A patch release in 4.6 branch extracted the CRDs from the bindata of prometheus operator. All required CRDs are now present by default even if the monitoring operator never ran. The procedure to activate monitoring is to remove the ClusterOperator and the Deployment from overrides. This method can be reused for other operators. At the end, all overrides should added before the cluster starts.
openshift-etcd namespace was not cleaned up. This method is more general
guillaumerose
force-pushed
the
monitoring
branch
from
b3e385a to
fd1efa1
Compare
|
/retest |
|
@guillaumerose: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@guillaumerose: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| group: apps/v1 | ||
| name: etcd-quorum-guard | ||
| namespace: openshift-machine-config-operator | ||
| - kind: ClusterOperator |
There was a problem hiding this comment.
@guillaumerose do we need those ClusterOperators as kind in the override list also, doesn't setting up the deployment as unmanagement works?
There was a problem hiding this comment.
yes it is needed as the installer is waiting for all cluster operators to be ready.
|
It's in master now. |
3 participants
The operator will never run and won't create what we used to delete.
It is cleaner and speed up a little bit cluster creation.
A patch release in 4.6 branch extracted the CRDs from the bindata of
prometheus operator. All required CRDs are now present by default even
if the monitoring operator never ran.
The procedure to activate monitoring is to remove the ClusterOperator
and the Deployment from overrides.
This method can be reused for other operators. At the end, all overrides
should added before the cluster starts.