Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry: do not return an error when identify hash file is malformed #4084

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

redbeam
Copy link
Contributor

@redbeam redbeam commented Mar 25, 2024

Fixes: Issue #4023

Solution/Idea

A malformed identify hash file should no longer trigger an error when reading it. Now there is a warning displayed and the hash file is treated like it doesn't exist yet. Therefore, it will be regenerated with the correct content.

Proposed changes

  1. Add a warning log to the console with a description of what is wrong and what will happen.
  2. Remove error from the return.

Testing

When the file does not exist yet, no warning should be shown. If it is malformed (does not contain exactly 8 bytes), the warning should show and after the program exits, the file should contain the correct hash.

@redbeam redbeam self-assigned this Mar 25, 2024
@openshift-ci openshift-ci bot requested review from anjannath and gbraad March 25, 2024 18:19
Copy link

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, gbraad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Mar 27, 2024

@redbeam: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration-crc cb46545 link true /test integration-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gbraad gbraad merged commit 0cd39c4 into main Mar 28, 2024
19 of 21 checks passed
@gbraad gbraad deleted the malformed_identify_hash branch March 28, 2024 03:13
@gbraad
Copy link
Contributor

gbraad commented Mar 28, 2024

Thank you for your first contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants