telemetry: do not return an error when identify hash file is malformed #4084
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: Issue #4023
Solution/Idea
A malformed identify hash file should no longer trigger an error when reading it. Now there is a warning displayed and the hash file is treated like it doesn't exist yet. Therefore, it will be regenerated with the correct content.
Proposed changes
Testing
When the file does not exist yet, no warning should be shown. If it is malformed (does not contain exactly 8 bytes), the warning should show and after the program exits, the file should contain the correct hash.