Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QE] Update go version on multistage Containerfile for qe images #4185

Closed
adrianriobo opened this issue May 29, 2024 · 0 comments
Closed

[QE] Update go version on multistage Containerfile for qe images #4185

adrianriobo opened this issue May 29, 2024 · 0 comments

Comments

@adrianriobo
Copy link
Contributor

adrianriobo commented May 29, 2024

With the latest versions update by dependabot 813c80a some of the dependencies on the e2e package now requires golang 1.21.

During the update to golang 1.21 we missed to update the Containerfiles for the qe images which is used as check on gh action and now is failing:

FROM registry.access.redhat.com/ubi8/go-toolset:1.20 AS builder

FROM registry.access.redhat.com/ubi8/go-toolset:1.20 AS builder

Also as per comment we should inspect Containerfile as a posible build spec where the update-version script should act in case of a golang update

anjannath added a commit to anjannath/crc that referenced this issue May 30, 2024
anjannath added a commit to anjannath/crc that referenced this issue Jun 3, 2024
this updates the update-go-version.sh script to also updaate go
versions in the files images/*/Containerfile

fixes crc-org#4185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant