Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Unnecessary logging crc-exists every second on Windows grows crcd.log #3676

Closed
gbraad opened this issue May 23, 2023 · 0 comments · Fixed by #4532
Closed

[BUG] Unnecessary logging crc-exists every second on Windows grows crcd.log #3676

gbraad opened this issue May 23, 2023 · 0 comments · Fixed by #4532
Assignees
@rohanKanojia
Labels
kind/bug Something isn't working os/windows points/1 priority/major

Comments

@gbraad
Copy link
Contributor

gbraad commented May 23, 2023 •
edited
Loading

General information

  • OS: Linux / macOS / Windows
  • Hypervisor: KVM / Hyper-V / hyperkit / vfkit
  • Did you run crc setup before starting it (Yes/No)?
  • Running CRC on: Laptop / Baremetal-Server / VM

The crcd.log file grows huge due to the following being logged:

time="2023-05-21T12:43:43+08:00" level=debug msg="Running 'Hyper-V\\Get-VM crc | Select-Object -ExpandProperty State'"
time="2023-05-21T12:43:44+08:00" level=debug msg="Checking file: C:\\Users\\gbraad\\.crc\\machines\\crc\\.crc-exist"
time="2023-05-21T12:43:44+08:00" level=debug msg="Checking file: C:\\Users\\gbraad\\.crc\\machines\\crc\\.crc-exist"

which is 352 bytes every second, or 1.2672 megabytes every hour, or 30.4128 megabytes every day... just logging this.
@anjannath anjannath moved this to Backlog in Project planning: crc Jun 13, 2023
@anjannath anjannath moved this from Backlog to In Progress in Project planning: crc Jun 16, 2023
@rohanKanojia rohanKanojia self-assigned this Dec 27, 2024
@rohanKanojia rohanKanojia moved this from Work In Progress to Todo in Project planning: crc Dec 27, 2024
rohanKanojia added a commit to rohankanojia-forks/crc that referenced this issue Dec 27, 2024
@rohanKanojia
fix : remove unnecessary logging for crc-exists file (crc-org#3676)
7b6b010 
Remove unnecessary debug log statement for crc-exists file from
filestore Exists() method

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia mentioned this issue Dec 30, 2024
Merged
12 tasks
rohanKanojia added a commit to rohankanojia-forks/crc that referenced this issue Dec 30, 2024
@rohanKanojia
fix : remove unnecessary logging for crc-exists file (crc-org#3676)
0171191 
Remove unnecessary debug log statement for crc-exists file from
filestore Exists() method

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia moved this from Todo to Work In Progress in Project planning: crc Dec 30, 2024
@rohanKanojia rohanKanojia moved this from Work In Progress to Ready for review in Project planning: crc Dec 30, 2024
rohanKanojia added a commit to rohankanojia-forks/crc that referenced this issue Jan 2, 2025
@rohanKanojia
fix : remove unnecessary logging for crc-exists file (crc-org#3676)
9a41c51 
Remove unnecessary debug log statement for crc-exists file from
filestore Exists() method. Only log debug statement when crc-exists file
is not found.

Signed-off-by: Rohan Kumar <[email protected]>
praveenkumar pushed a commit that referenced this issue Jan 2, 2025
@rohanKanojia @praveenkumar
fix : remove unnecessary logging for crc-exists file (#3676)
d89df4c 
Remove unnecessary debug log statement for crc-exists file from
filestore Exists() method. Only log debug statement when crc-exists file
is not found.

Signed-off-by: Rohan Kumar <[email protected]>
@github-project-automation github-project-automation bot moved this from Ready for review to Done in Project planning: crc Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
kind/bug Something isn't working os/windows points/1 priority/major
Projects
Project planning: crc
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix : remove unnecessary logging for crc-exists file (#3676) rohankanojia-forks/crc
2 participants
@gbraad @rohanKanojia