crc status should provide information on the preset used

[slemeur]

I've restarted an instance of OpenShift Local. No idea what is the preset

crc status should provide information on the preset used

[praveenkumar]

@slemeur we don't expose the preset as part of human readable status but it is part of json which is used by the tools ( like podman desktop and VS extensions). To end user if they use the podman preset then there would be no openshift version as part of status and for microshift/okd/openshift preset there is openshift version and that is what user more interested if the openshift is running or not and api is accessible instead preset. preset is important on tooling side so it is part of json output.

$ ./crc status -ojson
{
  "success": true,
  "crcStatus": "Running",
  "openshiftStatus": "Running",
  "openshiftVersion": "4.12.9",
  "diskUsage": 19659599872,
  "diskSize": 32737570816,
  "cacheUsage": 303515336903,
  "cacheDir": "/home/prkumar/.crc/cache",
  "ramSize": 9398726656,
  "ramUsage": 7564517376,
  "preset": "openshift"
}

[gbraad]

The preset is inferred from the message like: OpenShift version and the statements around this, or Podman version. We discussed to specifically add some clarity by stating Microshift V4.13, etc.

…

On Wed, May 3, 2023 at 8:28 PM Praveen Kumar ***@***.***> wrote: @slemeur <https://github.com/slemeur> we don't expose the preset as part of human readable status but it is part of json which is used by the tools ( like podman desktop and VS extensions). To end user if they use the podman preset then there would be no openshift version as part of status and for microshift/okd/openshift preset there is openshift version and that is what user more interested if the openshift is running or not and api is accessible instead preset. preset is important on tooling side so it is part of json output. $ ./crc status -ojson { "success": true, "crcStatus": "Running", "openshiftStatus": "Running", "openshiftVersion": "4.12.9", "diskUsage": 19659599872, "diskSize": 32737570816, "cacheUsage": 303515336903, "cacheDir": "/home/prkumar/.crc/cache", "ramSize": 9398726656, "ramUsage": 7564517376, "preset": "openshift" } — Reply to this email directly, view it on GitHub <#3626 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAOZVM4VXZTY2JFEOSF33XEJFPTANCNFSM6AAAAAAXUJ67GE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Gerard Braad | http://gbraad.nl STEM is the source, but BUILD is how you develop! [ Better Understanding Involves Learning and Doing ]

[rohanKanojia]

I want to work on this issue. Could someone please assign it to me?

[rohanKanojia]

Hello, I think we can add preset information in crc status just below CRC VM section like this:

CRC VM:                  Running
+CRC Preset:              microshift
MicroShift:              Starting (v4.16.14)
RAM Usage:               1.156GB of 3.821GB
Disk Usage:              5.086GB of 16.1GB (Inside the CRC VM)
Persistent Volume Usage: 0B of 15GB (Allocated)
Cache Usage:             12.56GB
Cache Directory:         /home/rokumar/.crc/cache

[praveenkumar]

Since now as part of status we show Microshift: Starting (v4.16.14) in case of microshift and OpenShift: Starting (v4.16.14) so doesn't that mean it is already solved and we don't have to add extra filed for UX?

[rohanKanojia]

@praveenkumar : From my outsider's perspective, it's still unclear. We can change the line format to CRC Preset : MicroShift (Starting v4.16.14)

[rohanKanojia]

Looking at code in status.go , we only seem to got OpenShift/ MicroShift status for openshift and microshift presets, not for okd:

crc/cmd/crc/cmd/status.go

Lines 198 to 202 in f71d9ce

	if s.Preset == preset.OpenShift {
	lines = append(lines, line{"OpenShift", openshiftStatus(s)})
	}
	if s.Preset == preset.Microshift {
	lines = append(lines, line{"MicroShift", openshiftStatus(s)})

[praveenkumar]

Looking at code in status.go , we only seem to got OpenShift/ MicroShift status for openshift and microshift presets, not for okd:

OKD/OCP from end user prospective is same because both consume same amount of resource. This request is came from because of resource requirement was different for OCP and podman preset (we didn't get any issue from user). @crc-org/crc-team wdyt?

[cfergeau]

crc status should be accurate about what we are running, if we are running OKD, don't mention openshift but print OKD. If you want to group okd and openshift under a common name, better to use one which is not ambiguous, eg OpenShift/OKD: ...