build: Move macos specific commands out of 'packagedir'

These 2 commands are the only things which prevent from running `make
packagedir`. Since `make packagedir` goes together with the
`packaging.sh` script, we can move these 2 commands there.
This should allow us to cross-build the macOS installer data on a linux
host, and then run the signing process on a macOS host.

An alternative would be to commit components.plist to git, which is an
option as the file does not look like it would change too often.
However, I'm not sure how to reliably detect the file has changed and
needs to be updated.

Makefile

@@ -331,8 +331,6 @@ packagedir: clean embed-download-darwin macos-universal-binary
 
 	cp $(BUILD_DIR)/macos-universal/crc packaging/root/"$(MACOS_INSTALL_PATH)"
 	cp LICENSE packaging/darwin/Resources/LICENSE.txt
-	pkgbuild --analyze --root packaging/root packaging/components.plist
-	plutil -replace BundleIsRelocatable -bool NO packaging/components.plist
 
 $(BUILD_DIR)/macos-universal/crc-macos-installer.pkg: packagedir
 	./packaging/package.sh $(@D)

packaging/package.sh

@@ -44,6 +44,9 @@ binDir="${BASEDIR}/root/Applications/Red Hat OpenShift Local.app/Contents/Resour
 
 version=$(cat "${BASEDIR}/VERSION")
 
+pkgbuild --analyze --root ${BASEDIR}/root ${BASEDIR}/components.plist
+plutil -replace BundleIsRelocatable -bool NO ${BASEDIR}/components.plist
+
 sign "${binDir}/crc"
 sign "${binDir}/crc-admin-helper-darwin"
 sign "${binDir}/vfkit"