Skip to content

Commit

Permalink
CI tester windows Use the run id to sync the artifacts fom the builde…
Browse files Browse the repository at this point in the history
…r to the tester

Previously the value passed from the trigger flow to the tester was using the github.event.workflow_run.workflow_id which identifies the worflow but no the exact execution; as so the artifacts were downloaded from the right workflow but they were not the ones built on that exact execution leading to a testing missmatch; this commit changes that value to use the github.event.workflow_run.id wihch matches the exact execution of the trigger workflow

Signed-off-by: Adrian Riobo Lorenzo <[email protected]>
  • Loading branch information
adrianriobo authored and praveenkumar committed May 8, 2024
1 parent c7bc3f2 commit e6f4209
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/windows-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- qe-type: 'integration'
preset: 'microshift'
with:
trigger-workflow-id: ${{ github.event.workflow_run.workflow_id }}
trigger-workflow-run-id: ${{ github.event.workflow_run.id }}
qe-type: ${{matrix.qe-type}}
preset: ${{matrix.preset}}
secrets: inherit
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/windows-qe-tpl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ name: windows-qe-tpl
on:
workflow_call:
inputs:
trigger-workflow-id:
trigger-workflow-run-id:
required: true
type: string
qe-type:
Expand Down Expand Up @@ -33,21 +33,21 @@ jobs:
id: download-gh-context-artifact
uses: dawidd6/action-download-artifact@v3
with:
workflow: ${{inputs.trigger-workflow-id}}
workflow: ${{inputs.trigger-workflow-run-id}}
name: gh-context

- name: Download windows installer
id: download-windows-installer-artifact
uses: dawidd6/action-download-artifact@v3
with:
workflow: ${{inputs.trigger-workflow-id}}
workflow: ${{inputs.trigger-workflow-run-id}}
name: windows-installer

- name: Download qe oci image
id: download-qe-oci-image-artifact
uses: dawidd6/action-download-artifact@v3
with:
workflow: ${{inputs.trigger-workflow-id}}
workflow: ${{inputs.trigger-workflow-run-id}}
name: crc-${{inputs.qe-type}}-windows-amd64

- name: Correlate
Expand Down

0 comments on commit e6f4209

Please sign in to comment.