Skip to content

Commit

Permalink
Cluster: Remove namespace details from proxy patch
Browse files Browse the repository at this point in the history
Proxy resource is cluster wide so it doesn't need namespace details
when applying the patch.

- https://docs.openshift.com/container-platform/latest/rest_api/config_apis/proxy-config-openshift-io-v1.html
  • Loading branch information
praveenkumar committed Sep 2, 2022
1 parent a568419 commit 905013d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/crc/cluster/cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ func AddProxyConfigToCluster(ctx context.Context, sshRunner *ssh.Runner, ocConfi
}
logging.Debugf("Patch string %s", string(patchEncode))

cmdArgs := []string{"patch", "proxy", "cluster", "-p", fmt.Sprintf("'%s'", string(patchEncode)), "-n", "openshift-config", "--type", "merge"}
cmdArgs := []string{"patch", "proxy", "cluster", "-p", fmt.Sprintf("'%s'", string(patchEncode)), "--type", "merge"}
if _, stderr, err := ocConfig.RunOcCommandPrivate(cmdArgs...); err != nil {
return fmt.Errorf("Failed to add proxy details %v: %s", err, stderr)
}
Expand Down

0 comments on commit 905013d

Please sign in to comment.