-
Notifications
You must be signed in to change notification settings - Fork 242
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use a constant for the version of admin-helper
earlier when parsing the version from the download URL the version is changed implicitly based on the tag used which doesn't reflect the version that is set on the binary for tags we prefer to use the github style with a v infront for the version in the binary we prefer to not use the v so tag v0.0.11 corresponds to version 0.0.11, using the crcAdminHelperVersion constant makes it explicit when bumping admin-helper version this fixes the following error on linux ``` unexpected version of the crc-admin-helper executable: crc-admin-helper-linux version mismatch: v0.0.11 expected but 0.0.11 found in the cache ```
- Loading branch information
1 parent
8c279e9
commit 8ac31f8
Showing
3 changed files
with
8 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters