Mask password in error returned when mounting CIFS share fails

this adds a new error type MaskedSecretError to the errors package

pkg/crc/errors/maskederror.go

@@ -0,0 +1,16 @@
+package errors
+
+import (
+	"strings"
+)
+
+const mask = "*****"
+
+type MaskedSecretError struct {
+	Err    error
+	Secret string
+}
+
+func (err *MaskedSecretError) Error() string {
+	return strings.ReplaceAll(err.Err.Error(), err.Secret, mask)
+}

pkg/crc/errors/maskederror_test.go

@@ -0,0 +1,16 @@
+package errors
+
+import (
+	"errors"
+	"fmt"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestMaskedError(t *testing.T) {
+	err := errors.New("The password is: pass@122")
+	maskedErr := &MaskedSecretError{err, "pass@122"}
+	expectedErrMsg := fmt.Sprintf("The password is: %s", mask)
+	assert.EqualError(t, maskedErr, expectedErrMsg)
+}

pkg/crc/machine/start.go

@@ -189,6 +189,10 @@ func configureSharedDirs(vm *virtualMachine, sshRunner *crcssh.Runner) error {
 		case "cifs":
 			smbUncPath := fmt.Sprintf("//%s/%s", hostVirtualIP, mount.Tag)
 			if _, _, err := sshRunner.RunPrivate("sudo", "mount", "-o", fmt.Sprintf("rw,uid=core,gid=core,username='%s',password='%s'", mount.Username, mount.Password), "-t", mount.Type, smbUncPath, mount.Target); err != nil {
+				err = &crcerrors.MaskedSecretError{
+					Err:    err,
+					Secret: mount.Password,
+				}
 				return fmt.Errorf("Failed to mount CIFS/SMB share '%s' please make sure configured password is correct: %w", mount.Tag, err)
 			}
 		default: