Skip to content

Commit

Permalink
dns: Remove 'wildcard' DNS check for usermode networking
Browse files Browse the repository at this point in the history
wildcard DNS won't work with usermode networking, and the warning is a
source of confusion. Better to disable this check when usermode is in
use, which is the default on macos and Windows.
  • Loading branch information
cfergeau authored and openshift-merge-robot committed Nov 28, 2022
1 parent 725fd52 commit 74fcae9
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions pkg/crc/services/dns/dns.go
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,12 @@ func CheckCRCLocalDNSReachableFromHost(serviceConfig services.ServicePostStartCo
return fmt.Errorf("Invalid IP for %s", apiHostname)
}

if serviceConfig.NetworkMode == network.UserNetworkingMode {
// user-mode networking does not setup wildcard DNS on the host. It relies on admin-helper
// to create entries in /etc/hosts for routes defined in the cluster.
return nil
}

if runtime.GOOS != "darwin" {
/* This check will fail with !CGO_ENABLED builds on darwin as
* in this case, /etc/resolver/ will not be used, so we won't
Expand Down

0 comments on commit 74fcae9

Please sign in to comment.