test: fix failing TestGenerateSSHKey on Windows

Windows does not allow removing an open file. We need to close all open file descriptors before we delete them. Signed-off-by: Eng Zer Jun <[email protected]>
crc-org · Nov 3, 2022 · 5847f99 · 5847f99
1 parent fa9e605
commit 5847f99
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/pkg/crc/ssh/keys_unix.go b/pkg/crc/ssh/keys_unix.go
@@ -30,6 +30,7 @@ func (kp *KeyPair) WriteToFile(privateKeyPath string, publicKeyPath string) erro
 		if err != nil {
 			return ErrUnableToWriteFile
 		}
+		defer f.Close()
 
 		if _, err := f.Write(v.Value); err != nil {
 			return ErrUnableToWriteFile

diff --git a/pkg/crc/ssh/keys_windows.go b/pkg/crc/ssh/keys_windows.go
@@ -29,6 +29,7 @@ func (kp *KeyPair) WriteToFile(privateKeyPath string, publicKeyPath string) erro
 		if err != nil {
 			return ErrUnableToWriteFile
 		}
+		defer f.Close()
 
 		if _, err := f.Write(v.Value); err != nil {
 			return ErrUnableToWriteFile
@@ -37,7 +38,6 @@ func (kp *KeyPair) WriteToFile(privateKeyPath string, publicKeyPath string) erro
 		if err := acl.Chmod(v.File, 0600); err != nil {
 			return err
 		}
-
 	}
 
 	return nil