move initialization of SharedDirs to driver's CreatHost function

options needed for the shared dirs such as the source path, target path
and types etc. differs between drivers and its best to configure  those
at the specific driver level

although currently both libvirt and vfkit have the same options for their
shared directories, hyperv will have different options to use smb instead
of virtiofs

pkg/crc/machine/config/driver.go

@@ -1,8 +1,6 @@
 package config
 
 import (
-	"fmt"
-
 	"github.com/code-ready/machine/libmachine/drivers"
 )
 
@@ -17,13 +15,4 @@ func InitVMDriverFromMachineConfig(machineConfig MachineConfig, driver *drivers.
 	driver.BundleName = machineConfig.BundleName
 	driver.ImageSourcePath = machineConfig.ImageSourcePath
 	driver.ImageFormat = machineConfig.ImageFormat
-
-	for i, dir := range machineConfig.SharedDirs {
-		sharedDir := drivers.SharedDir{
-			Source: dir,
-			Target: dir,
-			Tag:    fmt.Sprintf("dir%d", i),
-		}
-		driver.SharedDirs = append(driver.SharedDirs, sharedDir)
-	}
 }

pkg/crc/machine/libvirt/driver_linux.go

@@ -1,10 +1,13 @@
 package libvirt
 
 import (
+	"fmt"
+
 	"github.com/code-ready/crc/pkg/crc/constants"
 	"github.com/code-ready/crc/pkg/crc/machine/config"
 	"github.com/code-ready/crc/pkg/crc/network"
 	"github.com/code-ready/machine/drivers/libvirt"
+	"github.com/code-ready/machine/libmachine/drivers"
 )
 
 func CreateHost(machineConfig config.MachineConfig) *libvirt.Driver {
@@ -20,5 +23,21 @@ func CreateHost(machineConfig config.MachineConfig) *libvirt.Driver {
 	}
 
 	libvirtDriver.StoragePool = DefaultStoragePool
+	libvirtDriver.SharedDirs = configureShareDirs(machineConfig)
+
 	return libvirtDriver
 }
+
+func configureShareDirs(machineConfig config.MachineConfig) []drivers.SharedDir {
+	var sharedDirs []drivers.SharedDir
+	for i, dir := range machineConfig.SharedDirs {
+		sharedDir := drivers.SharedDir{
+			Source: dir,
+			Target: dir,
+			Tag:    fmt.Sprintf("dir%d", i),
+			Type:   "virtiofs",
+		}
+		sharedDirs = append(sharedDirs, sharedDir)
+	}
+	return sharedDirs
+}

pkg/crc/machine/start.go

@@ -173,10 +173,13 @@ func configureSharedDirs(vm *virtualMachine, sshRunner *crcssh.Runner) error {
 			}
 		}
 		logging.Debugf("Mounting tag %s at %s", mount.Tag, mount.Target)
-		//FIXME: do not hardcode this
-		mount.Type = "virtiofs"
-		if _, _, err := sshRunner.RunPrivileged(fmt.Sprintf("Mounting %s", mount.Target), "mount", "-o", "context=\"system_u:object_r:container_file_t:s0\"", "-t", mount.Type, mount.Tag, mount.Target); err != nil {
-			return err
+		switch mount.Type {
+		case "virtiofs":
+			if _, _, err := sshRunner.RunPrivileged(fmt.Sprintf("Mounting %s", mount.Target), "mount", "-o", "context=\"system_u:object_r:container_file_t:s0\"", "-t", mount.Type, mount.Tag, mount.Target); err != nil {
+				return err
+			}
+		default:
+			return fmt.Errorf("Unknown Shared dir type requested: %s", mount.Type)
 		}
 	}
 

pkg/crc/machine/vfkit/driver_darwin.go

@@ -1,12 +1,14 @@
 package vfkit
 
 import (
+	"fmt"
 	"path/filepath"
 
 	"github.com/code-ready/crc/pkg/crc/constants"
 	"github.com/code-ready/crc/pkg/crc/machine/config"
 	"github.com/code-ready/crc/pkg/crc/network"
 	"github.com/code-ready/crc/pkg/drivers/vfkit"
+	"github.com/code-ready/machine/libmachine/drivers"
 )
 
 func CreateHost(machineConfig config.MachineConfig) *vfkit.Driver {
@@ -22,5 +24,21 @@ func CreateHost(machineConfig config.MachineConfig) *vfkit.Driver {
 	vfDriver.VirtioNet = machineConfig.NetworkMode == network.SystemNetworkingMode
 	vfDriver.VsockPath = constants.TapSocketPath
 
+	vfDriver.SharedDirs = configureShareDirs(machineConfig)
+
 	return vfDriver
 }
+
+func configureShareDirs(machineConfig config.MachineConfig) []drivers.SharedDir {
+	var sharedDirs []drivers.SharedDir
+	for i, dir := range machineConfig.SharedDirs {
+		sharedDir := drivers.SharedDir{
+			Source: dir,
+			Target: dir,
+			Tag:    fmt.Sprintf("dir%d", i),
+			Type:   "virtiofs",
+		}
+		sharedDirs = append(sharedDirs, sharedDir)
+	}
+	return sharedDirs
+}