Skip to content

Commit

Permalink
machine: Print log when downloading bundle
Browse files Browse the repository at this point in the history
Running `crc start` without the expected bundle available shows a
download progress bar without saying first what it's doing:

INFO Checking if crc daemon plist file is present and loaded
1.73 GiB / 3.09 GiB [------------------>___________________]

This commit adds a "Downloading .." line before to inform the user about
this lengthy operation.
  • Loading branch information
cfergeau authored and openshift-merge-robot committed Nov 28, 2022
1 parent a5f90a2 commit 123f612
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions pkg/crc/machine/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ func getCrcBundleInfo(preset crcPreset.Preset, bundleName, bundlePath string) (*
return bundleInfo, nil
}
logging.Debugf("Failed to load bundle %s: %v", bundleName, err)
logging.Infof("Downloading bundle: %s...", bundleName)
bundlePath, err = bundle.Download(preset, bundlePath)
if err != nil {
return nil, err
Expand Down
1 change: 1 addition & 0 deletions pkg/crc/preflight/preflight_checks_common.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ func fixBundleExtracted(bundlePath string, preset crcpreset.Preset) func() error
}

var err error
logging.Infof("Downloading bundle: %s...", bundlePath)
if bundlePath, err = bundle.Download(preset, bundlePath); err != nil {
return err
}
Expand Down

0 comments on commit 123f612

Please sign in to comment.