Skip to content

Commit

Permalink
Makefile: Add build tags for build integration target
Browse files Browse the repository at this point in the history
Looks like it is missed during 63637fe
and build_integration target failing with following.
```
[1/2] STEP 5/5: RUN make build_integration
GOOS=linux   go test ./test/integration/ --ldflags="-X github.com/code-ready/crc/pkg/crc/version.crcVersion=2.9.0 -X github.com/code-ready/crc/pkg/crc/version.ocpVersion=4.11.3 -X github.com/code-ready/crc/pkg/crc/version.okdVersion=4.11.0-0.okd-2022-08-20-022919 -X github.com/code-ready/crc/pkg/crc/version.podmanVersion=4.2.0 -X github.com/code-ready/crc/pkg/crc/version.commitSha=589ab2cd" -c -o out/linux-amd64/integration.test
vendor/github.com/mtrmac/gpgme/data.go:4:11: fatal error: gpgme.h: No such file or directory
 // #include <gpgme.h>
           ^~~~~~~~~
compilation terminated.
```
  • Loading branch information
praveenkumar authored and anjannath committed Sep 20, 2022
1 parent 589ab2c commit 0bd8952
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,9 @@ build_e2e: $(SOURCES)

.PHONY: build_integration
build_integration: $(SOURCES)
GOOS=linux go test ./test/integration/ --ldflags="$(VERSION_VARIABLES)" -c -o $(BUILD_DIR)/linux-amd64/integration.test
GOOS=windows go test --ldflags="-X $(REPOPATH)/pkg/crc/version.installerBuild=true $(VERSION_VARIABLES)" ./test/integration/ -c -o $(BUILD_DIR)/windows-amd64/integration.test.exe
GOOS=darwin go test --ldflags="-X $(REPOPATH)/pkg/crc/version.installerBuild=true $(VERSION_VARIABLES)" ./test/integration/ -c -o $(BUILD_DIR)/macos-amd64/integration.test
GOOS=linux go test ./test/integration/ -tags "$(BUILDTAGS)" --ldflags="$(VERSION_VARIABLES)" -c -o $(BUILD_DIR)/linux-amd64/integration.test
GOOS=windows go test -tags "$(BUILDTAGS)" --ldflags="-X $(REPOPATH)/pkg/crc/version.installerBuild=true $(VERSION_VARIABLES)" ./test/integration/ -c -o $(BUILD_DIR)/windows-amd64/integration.test.exe
GOOS=darwin go test -tags "$(BUILDTAGS)" --ldflags="-X $(REPOPATH)/pkg/crc/version.installerBuild=true $(VERSION_VARIABLES)" ./test/integration/ -c -o $(BUILD_DIR)/macos-amd64/integration.test

# Build the container image for e2e
.PHONY: containerized_e2e
Expand Down

0 comments on commit 0bd8952

Please sign in to comment.