Skip to content

Commit

Permalink
vfkit: Remove unneeded 'WaitForConnectivity'
Browse files Browse the repository at this point in the history
By the time updateKernelArgs is called, the VM should be up, so we
should not need to explicitly wait for SSH connectivity before running
our SSH commands.
  • Loading branch information
cfergeau authored and anjannath committed Aug 30, 2022
1 parent 6c429df commit 06131a5
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions pkg/crc/machine/driver_darwin.go
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
package machine

import (
"context"
"encoding/json"
"errors"
"time"

"github.com/code-ready/crc/pkg/crc/constants"
"github.com/code-ready/crc/pkg/crc/logging"
Expand Down Expand Up @@ -47,10 +45,6 @@ func updateKernelArgs(vm *virtualMachine) error {
}
defer sshRunner.Close()

if err := sshRunner.WaitForConnectivity(context.Background(), 20*time.Second); err != nil {
return err
}

stdout, stderr, err := sshRunner.RunPrivileged("Get kernel args", `-- sh -c 'rpm-ostree kargs'`)
if err != nil {
logging.Errorf("Failed to get kernel args: %v - %s", err, stderr)
Expand Down

0 comments on commit 06131a5

Please sign in to comment.