Remove createJSModules - RN 0.47 compatibility #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Typo. It should be deprecated |
|
@jaggs6, thanks fixed. |
ohtangza
approved these changes
Aug 8, 2017
There was a problem hiding this comment.
Great.
With this commit, it also has backward-compatibility as facebookarchive/react-native-fbsdk@f0523e7
|
It might close #75. |
|
Yeah, I just closed the issue |
|
+1 for seeing this merged in ASAP. It's blocking us. |
|
Any news when will be ready? |
|
Closes #82 |
This was referenced Aug 17, 2017
Closed
|
@crazycodeboy Please merge! |
|
Released at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createJSModulesis now not required on Android from RN 0.47. I actually can't build an app on RN 0.47 without removing this method. This is backwards compatible according to my tests.