Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to android/build.gradle #328

Merged
merged 2 commits into from
Feb 7, 2019
Merged

Update to android/build.gradle #328

merged 2 commits into from
Feb 7, 2019

Conversation

Shhzdmrz
Copy link
Contributor

@Shhzdmrz Shhzdmrz commented Nov 4, 2018 •
edited
Loading

Related to issue fixes #327, fixes #311, closes #307
WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html

@Shhzdmrz
Update to android/build.gradle
35e47d5 
Related to issue crazycodeboy#327
WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html
@rodrigowpl
Copy link

This PR is ok? Anybody can take a look?

@MrLoh MrLoh mentioned this pull request Dec 19, 2018
Closed
@MrLoh
Copy link

MrLoh commented Dec 19, 2018

This is ok, please merge @crazycodeboy

@Shhzdmrz
Update build.gradle
d3f6fe3 
compile should be updated to implementation.
@kingdark1234
Copy link

Please merge this pr @crazycodeboy

@mikehardy
Copy link

I'm primarily an Android developer at this point.
I just reviewed it, the changes look fine to me

@vitorreis
Copy link
Contributor

@crazycodeboy could you please give an update in this thread?

portons pushed a commit to portons/react-native-splash-screen that referenced this pull request Jan 16, 2019
Update react-native-splash-screen with PRs fixes for Android & iOS:
84ef269 
- iOS: crazycodeboy#342
- Android: crazycodeboy#328
@chicio
Copy link

chicio commented Jan 21, 2019

Hi @crazycodeboy ,
can you please merge this PR?. Your library doesn't compile with the new version of Android Studio 3.3.

@shaneog
Copy link

shaneog commented Jan 30, 2019

Please merge this PR.

@liamdidatofusion
Copy link

Please merge this.

@markwongsoontorn
Copy link

Please merge the PR 👍 🥇

@mikehardy
Copy link

I have great success with the "patch-package" npm package, in combination with this patch, in the meantime...
react-native-splash-screen+3.1.1.patch.zip

@MrLoh
Copy link

MrLoh commented Feb 5, 2019

@crazycodeboy please take some responsibility for the packages you publish or find new maintainers. It's understandable that you are busy, but it is very frustrating when package maintainers go completely MIA.

@crazycodeboy crazycodeboy merged commit c9e090b into crazycodeboy:master Feb 7, 2019
This was referenced Feb 8, 2019
Open
Open
Closed
@A2booky A2booky mentioned this pull request Aug 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Titozzz Titozzz Titozzz approved these changes

@matteinn matteinn matteinn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone