Fix error deleting keys with short key id #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error: ``` gpg: can't do this in batch mode ``` The GPG command: ``` gpg --batch --yes --delete-secret-keys FINGERPRINT ``` requires to use a fingerprint if you use the `--batch` option. We were using the short ID of the primary key.
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
=======================================
Coverage 81.96% 81.96%
=======================================
Files 3 3
Lines 122 122
Branches 25 25
=======================================
Hits 100 100
Misses 11 11
Partials 11 11 Continue to review full report at Codecov.
|
lopopolo
added a commit
to artichoke/nightly
that referenced
this pull request
Jul 31, 2022
`artichoke/ghaction-import-gpg` is synced from upstream which includes several new releases, including a breaking change to v5 which upgrades the nodejs runtime version. The tag in `artichoke/ghaction-import-gpg` is: - https://github.com/artichoke/ghaction-import-gpg/tree/v5.1.0 Diff of the upgrade from v4.1.0 to v5.1.0 is: - https://github.com/artichoke/ghaction-import-gpg/compare/v4.1.0..v5.1.0. The diff is mostly tests and linting, with some changes to how key fingerprints and subkeys are handled, most notably: - crazy-max/ghaction-import-gpg#123 - crazy-max/ghaction-import-gpg#125 - crazy-max/ghaction-import-gpg#129 `artichoke/nightly` uses a signing subkey, so these fixes are good to take.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #124 (comment)
Error:
The GPG command:
requires to use a fingerprint if you use the
--batchoption.We were using the short ID of the primary key.