Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No EOLs on simplewall files #238

Closed
ghost opened this issue Jun 20, 2020 · 5 comments
Closed

No EOLs on simplewall files #238

ghost opened this issue Jun 20, 2020 · 5 comments

Comments

@ghost
Copy link

ghost commented Jun 20, 2020

Hi,

I use all three simplewall files,

https://raw.githubusercontent.com/crazy-max/WindowsSpyBlocker/master/data/dnscrypt/extra.txt
https://raw.githubusercontent.com/crazy-max/WindowsSpyBlocker/master/data/dnscrypt/spy.txt
https://raw.githubusercontent.com/crazy-max/WindowsSpyBlocker/master/data/dnscrypt/update.txt

which I all merge with several other blocklists.

Unfortunately all three miss an EOL with the obvious consequence that last item gets mixed with first item of following file in the merge process.
At this time I have to add a FileAppend , \n, [FILE] in order to get things done correctly (Autohotkey scripting).

Thanks!

@crazy-max
Copy link
Owner

crazy-max commented Jun 26, 2020

Hi @Cade66,

Since you do it programmatically, continue with your method.

@liamengland1
Copy link

liamengland1 commented Jun 27, 2020

@crazy-max Just add a newline, it's not that hard...?

@ghost
Copy link
Author

ghost commented Jun 27, 2020

All lists I use include a final blank line, pity not these three.
I can manage programmatically as noted above but I have in mind those who may merge several blacklists without being aware of the possible mix (unless next file starts itself with a blank line of course).

EDIT: In fact I had encountered another blocklist which didn't end with an EOL, but the developer corrected it:

@crazy-max
Copy link
Owner

@Cade66 This is now fixed

@ghost
Copy link
Author

ghost commented Aug 24, 2020

@crazy-max , indeed. I removed the add of a blank line accordingly for all three lists and all is OK, of course.
Merging scripts could very well add an EOL to all lists of course, given the process removes them once the job is done, and that could be a pertinent caution practice, but not sure they all do (mine didn't) and that can lead to two missed items at least.
Thanks for notifying the enhancement.
I already use all three of your blocking lists in their IP version with the Windows Privacy Dashboard application, adding the three domain equivalences is an extra caution, here.
Thanks for your work, most appreciated by many, obviously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants