-
Notifications
You must be signed in to change notification settings - Fork 2
Driver: Add page about Erlang #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds an Erlang driver card to the Connect index and a new Changes
Sequence Diagram(s)sequenceDiagram
participant App as Erlang app
participant Driver as epgsql / ODBC
participant CrateDB as CrateDB (Local / Cloud)
rect rgba(220,240,255,0.6)
App->>Driver: configure deps / start
Driver->>CrateDB: connect(host, port, ssl_opts / conn_str)
alt connection succeeds
App->>Driver: execute query
Driver->>CrateDB: send SQL
CrateDB-->>Driver: result set
Driver-->>App: return results
else connection fails
CrateDB-->>Driver: error
Driver-->>App: error / cleanup
end
App->>Driver: close / cleanup
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (3)
🧰 Additional context used🧠 Learnings (4)📚 Learning: 2025-10-16T10:58:18.401ZApplied to files:
📚 Learning: 2025-10-20T21:49:18.785ZApplied to files:
📚 Learning: 2025-10-08T01:34:18.867ZApplied to files:
📚 Learning: 2025-08-05T07:14:57.416ZApplied to files:
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
88d2bbf to
fe84566
Compare
374aa50 to
7557687
Compare
b8d2f40 to
589b8a4
Compare
| init:stop(). | ||
| ``` | ||
|
|
||
| :::{rubric} CrateDB Cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the ssl example is not only relevant for the cloud, so I would change the title to SSL connection or similar and then explain that this is mandatory for cloud.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added an adjustment: 6398449. Let me know if you want to phrase it differently, or add a suggestion right away. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if I wasn't clear, I meant about the header CreateDB Cloud.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I am confused? The commit replaces the header :::{rubric} CrateDB Cloud with :::{rubric} SSL connection, as you suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it in the commit, but not in the PR somehow, anyway I'm approving, maybe some github hiccup? you'll figure it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fixed in the epgsql file but not here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was clearly an oversight, thanks. I've fixed it with GH-474.
NB: Somehow I memorized that Erlang/ODBC/SSL would not be possible / failed for me while exercising it the other day. Apparently, I remembered it wrongly, but that's the reason I didn't look into this file again. Thanks for your understanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
| init:stop(). | ||
| ``` | ||
|
|
||
| :::{rubric} CrateDB Cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it in the commit, but not in the PR somehow, anyway I'm approving, maybe some github hiccup? you'll figure it out.
| :::{rubric} SSL connection | ||
| ::: | ||
|
|
||
| Start the Erlang [SSL application] first, | ||
| use the `ssl` and `ssl_opts` arguments on `epgsql:connect`, and | ||
| replace username, password, and hostname with values matching | ||
| your environment. | ||
|
|
||
| Also use this variant to connect to CrateDB Cloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @matriv: This is the new text. It is included in the PR for me. Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another place (odbc) which also says Cloud
About
What the title says.
Preview
https://cratedb-guide--420.org.readthedocs.build/connect/erlang/