Navigation: Add header menu items from website #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matkuliak
force-pushed
the
mm/top-navigation-edit
branch
3 times, most recently
from
dd9dd5e
to
67f0fe0
Compare
matkuliak
changed the title
matkuliak
force-pushed
the
mm/top-navigation-edit
branch
3 times, most recently
from
1b354c8
to
c6f66a7
Compare
|
Hi @msbt, rough draft of the navigation similar to our main site. I'm not really familiar with all the css in our docs, it's split into a couple of files so I mostly made new classes. Let me know if I should shuffle some stuff elsewhere. Thanks! |
|
Thanks. Isn't this supposed to go into some SSI snippet? |
|
Not sure. After pushing, @msbt let me know about https://cratedb.com/_hcms/api/navi-header. That was previously used as a dynamic source for the list through ESI. So going to switch to that probably |
matkuliak
force-pushed
the
mm/top-navigation-edit
branch
from
1e42b2c
to
ad9383c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
We want to bring the top navigation from main page to the docs:
Preview
https://crate-docs-theme--534.org.readthedocs.build/en/534/
cc @geragray