Skip to content

fix(cli): Improve color formatting #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 27, 2023
Merged

fix(cli): Improve color formatting #864

merged 4 commits into from
Oct 27, 2023

Conversation

@epage
Copy link
Collaborator

@epage epage commented Oct 27, 2023

  • Better matched rustc color choices (bright colors, rather than normal)
    • I intentionally kept to these colors, rather than the suggested yellow file path, because its more "positive" (yellow is more associated with negative things like warnings)
  • Better matched rustc in what gets colored
  • Went ahead and deviated from rustc in coloring the parts within the message
    • This works especially well for --format brief but I think it works well enough in --format long to justify the deviation

--format long

Before

Screenshot from 2023-10-27 09-32-01

After

Screenshot from 2023-10-27 09-32-26

--format brief

Before

Screenshot from 2023-10-27 09-32-42

After

Screenshot from 2023-10-27 09-32-55

Fixes #863

epage added 4 commits October 27, 2023 09:15
@epage
refactor(cli): Simplify palette handling
56eef88 
This did include a couple of tweaks to make it closer to rustc
@epage
fix(cli): Better match rustc's color choices
686e4ce 
I missed that rustc was using "bright" colors
@epage
fix(cli): Add styling to --file-types
1ca3216
@epage
fix(cli): Make the correction stand out more
0a5b4ab 
This does deviate from rustc for `long` format but it seems worth it.

I did move backticks to be out of the coloring so the `error:` was more
distinct from the typo in `long` format.
@epage epage mentioned this pull request Oct 27, 2023
Closed
@szepeviktor
Copy link
Contributor

szepeviktor commented Oct 27, 2023

Thank you for the light blue!
I will be able to read that on black bg.

@epage epage merged commit 6a7b7d0 into crate-ci:master Oct 27, 2023
@epage epage deleted the color branch October 27, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@szepeviktor szepeviktor szepeviktor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Readable colors

2 participants

@epage @szepeviktor